Compile remoting client plugin with GN

net/net.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file is shared between the regular GYP build, the NaCl GYP build, and
 # the GN build. For GN support, it must have no conditionals or anything like
 # that beyond the simple one-level-deep dictionary of values.
 {
   'variables': {
     # Subset of net source files that are compiled for NaCl (net_nacl target).
@@ skipping 138 matching lines @@
       'socket/client_socket_handle.cc',
       'socket/client_socket_handle.h',
       'socket/connection_attempts.h',
       'socket/next_proto.cc',
       'socket/next_proto.h',
       'socket/socket.h',
       'socket/ssl_client_socket.cc',
       'socket/ssl_client_socket.h',
       'socket/ssl_client_socket_openssl.cc',
       'socket/ssl_client_socket_openssl.h',
-      'socket/ssl_client_socket_pool.cc',
-      'socket/ssl_client_socket_pool.h',

[davidben, 2015/08/28 17:08:27]

Why were these changes needed? (I certainly believe that you don't need these
files. Just not what it has to do with GN. Does some stricter checking somewhere
cause problems?)

[Sergey Ulanov, 2015/08/31 21:59:33]

The files I moved here should not be part of net_nacl_common_sources because
they have dependencies on files that are not on this list. With GYP the lib was
compiled to .a archive, and these unmet dependency were ignored when linking.
With GN src/net is linked as bunch of .o files without .a, so now it tries to
resolve all symbols in this files and fails to link them. 

[davidben, 2015/08/31 23:11:06]

Gotcha. Thanks for clarifying.

       'socket/ssl_socket.h',
       'ssl/channel_id_service.cc',
       'ssl/channel_id_service.h',
       'ssl/channel_id_store.cc',
       'ssl/channel_id_store.h',
       'ssl/default_channel_id_store.cc',
       'ssl/default_channel_id_store.h',
       'ssl/openssl_client_key_store.cc',
       'ssl/openssl_client_key_store.h',
       'ssl/client_key_store.cc',
@@ skipping 110 matching lines @@
       'quic/crypto/quic_random.h',
       'quic/crypto/quic_server_info.cc',
       'quic/crypto/quic_server_info.h',
       'quic/crypto/scoped_evp_aead_ctx.cc',
       'quic/crypto/scoped_evp_aead_ctx.h',
       'quic/crypto/strike_register.cc',
       'quic/crypto/strike_register.h',
       'quic/crypto/strike_register_client.h',
       'quic/iovector.cc',
       'quic/iovector.h',
-      'quic/network_connection.cc',
-      'quic/network_connection.h',
       'quic/p2p/quic_p2p_crypto_config.cc',
       'quic/p2p/quic_p2p_crypto_config.h',
       'quic/p2p/quic_p2p_crypto_stream.cc',
       'quic/p2p/quic_p2p_crypto_stream.h',
       'quic/p2p/quic_p2p_session.cc',
       'quic/p2p/quic_p2p_session.h',
       'quic/p2p/quic_p2p_stream.cc',
       'quic/p2p/quic_p2p_stream.h',
       'quic/port_suggester.cc',
       'quic/port_suggester.h',
@@ skipping 22 matching lines @@
       'quic/quic_connection_stats.h',
       'quic/quic_crypto_client_stream.cc',
       'quic/quic_crypto_client_stream.h',
       'quic/quic_crypto_client_stream_factory.h',
       'quic/quic_crypto_server_stream.cc',
       'quic/quic_crypto_server_stream.h',
       'quic/quic_crypto_stream.cc',
       'quic/quic_crypto_stream.h',
       'quic/quic_data_reader.cc',
       'quic/quic_data_reader.h',
-      'quic/quic_data_stream.cc',
-      'quic/quic_data_stream.h',
       'quic/quic_data_writer.cc',
       'quic/quic_data_writer.h',
       'quic/quic_default_packet_writer.cc',
       'quic/quic_default_packet_writer.h',
       'quic/quic_fec_group.cc',
       'quic/quic_fec_group.h',
       'quic/quic_flags.cc',
       'quic/quic_flags.h',
       'quic/quic_flow_controller.cc',
       'quic/quic_flow_controller.h',
       'quic/quic_framer.cc',
       'quic/quic_framer.h',
       'quic/quic_packet_creator.cc',
       'quic/quic_packet_creator.h',
       'quic/quic_packet_generator.cc',
       'quic/quic_packet_generator.h',
       'quic/quic_packet_reader.cc',
       'quic/quic_packet_reader.h',
       'quic/quic_packet_writer.h',
       'quic/quic_protocol.cc',
       'quic/quic_protocol.h',
       'quic/quic_received_packet_manager.cc',
       'quic/quic_received_packet_manager.h',
-      'quic/quic_reliable_client_stream.cc',
-      'quic/quic_reliable_client_stream.h',

[davidben, 2015/08/28 17:08:27]

Someone from QUIC should probably review this. I'm not clear on how subsetting
QUIC works. I'm guessing you want quic/p2p but don't care about anything
implementing SPDY things?

+rch

[Sergey Ulanov, 2015/08/31 21:59:33]

That's right. We need to avoid all SPDY dependencies because they pull bunch of
other stuff that we don't need, e.g. zlib.

[Ryan Hamilton, 2015/09/02 19:22:58]

Makes sense to me.

       'quic/quic_sent_entropy_manager.cc',
       'quic/quic_sent_entropy_manager.h',
       'quic/quic_sent_packet_manager.cc',
       'quic/quic_sent_packet_manager.h',
       'quic/quic_server_id.cc',
       'quic/quic_server_id.h',
       'quic/quic_session.cc',
       'quic/quic_session.h',
       'quic/quic_socket_address_coder.cc',
       'quic/quic_socket_address_coder.h',
-      'quic/quic_spdy_session.cc',
-      'quic/quic_spdy_session.h',
       'quic/quic_stream_sequencer.cc',
       'quic/quic_stream_sequencer.h',
       'quic/quic_sustained_bandwidth_recorder.cc',
       'quic/quic_sustained_bandwidth_recorder.h',
       'quic/quic_time.cc',
       'quic/quic_time.h',
       'quic/quic_types.cc',
       'quic/quic_types.h',
       'quic/quic_unacked_packet_map.cc',
       'quic/quic_unacked_packet_map.h',
@@ skipping 618 matching lines @@
       'proxy/proxy_service.cc',
       'proxy/proxy_service.h',
       'quic/crypto/aead_base_decrypter_nss.cc',
       'quic/crypto/aead_base_encrypter_nss.cc',
       'quic/crypto/aes_128_gcm_12_decrypter_nss.cc',
       'quic/crypto/aes_128_gcm_12_encrypter_nss.cc',
       'quic/crypto/chacha20_poly1305_decrypter_nss.cc',
       'quic/crypto/chacha20_poly1305_encrypter_nss.cc',
       'quic/crypto/channel_id_nss.cc',
       'quic/crypto/p256_key_exchange_nss.cc',
+      'quic/network_connection.cc',
+      'quic/network_connection.h',
       'quic/quic_chromium_client_session.cc',
       'quic/quic_chromium_client_session.h',
       'quic/quic_client_session_base.cc',
       'quic/quic_client_session_base.h',
+      'quic/quic_data_stream.cc',
+      'quic/quic_data_stream.h',
       'quic/quic_headers_stream.cc',
       'quic/quic_headers_stream.h',
       'quic/quic_http_stream.cc',
       'quic/quic_http_stream.h',
       'quic/quic_http_utils.cc',
       'quic/quic_http_utils.h',
+      'quic/quic_reliable_client_stream.cc',
+      'quic/quic_reliable_client_stream.h',
+      'quic/quic_spdy_session.cc',
+      'quic/quic_spdy_session.h',
       'quic/quic_stream_factory.cc',
       'quic/quic_stream_factory.h',
       'quic/spdy_utils.cc',
       'quic/spdy_utils.h',
       'sdch/sdch_owner.cc',
       'sdch/sdch_owner.h',
       'socket/client_socket_factory.cc',
       'socket/client_socket_factory.h',
       'socket/client_socket_pool.cc',
       'socket/client_socket_pool.h',
@@ skipping 14 matching lines @@
       'socket/socket_net_log_params.cc',
       'socket/socket_net_log_params.h',
       'socket/socks5_client_socket.cc',
       'socket/socks5_client_socket.h',
       'socket/socks_client_socket.cc',
       'socket/socks_client_socket.h',
       'socket/socks_client_socket_pool.cc',
       'socket/socks_client_socket_pool.h',
       'socket/ssl_client_socket_nss.cc',
       'socket/ssl_client_socket_nss.h',
+      'socket/ssl_client_socket_pool.cc',
+      'socket/ssl_client_socket_pool.h',
       'socket/ssl_server_socket.h',
       'socket/ssl_server_socket_nss.cc',
       'socket/ssl_server_socket_nss.h',
       'socket/ssl_server_socket_openssl.cc',
       'socket/ssl_server_socket_openssl.h',
       'socket/stream_socket.cc',
       'socket/stream_socket.h',
       'socket/tcp_client_socket.cc',
       'socket/tcp_client_socket.h',
       'socket/tcp_server_socket.cc',
@@ skipping 811 matching lines @@
       'README.md',
       'docs/bug-triage.md',
       'docs/bug-triage-labels.md',
       'docs/bug-triage-suggested-workflow.md',
       'docs/life-of-a-url-request.md',
       'sdch/README.md',
     ],
     'net_docs_output_dir': '<(PRODUCT_DIR)/net/docs',
   }
 }