Compile remoting client plugin with GN

Compile remoting client plugin with GN

BUG=512899
Committed: https://crrev.com/99d83f9b9121d659cdbf259ec9f71f8d1f090100
Cr-Commit-Position: refs/heads/master@{#348752}

[Sergey Ulanov, 2015-08-27 23:28:00]

sergeyu@chromium.org changed reviewers:
+ davidben@chromium.org, garykac@chromium.org

[Sergey Ulanov, 2015-08-27 23:28:00]

David, please review changes in crypto, net and third_party/boringssl.
Gary, please review the rest.

https://codereview.chromium.org/1312463005/diff/1/crypto/BUILD.gn
File crypto/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/1/crypto/BUILD.gn#newcode8
crypto/BUILD.gn:8: component("crypto") {
This looks like a big change, but I just moved the component out of the "if
(is_nacl)" and added nacl_io dependency.

[davidben, 2015-08-28 17:08:27]

davidben@chromium.org changed reviewers:
+ rch@chromium.org

[davidben, 2015-08-28 17:08:27]

+rch for QUIC question below.

https://codereview.chromium.org/1312463005/diff/1/crypto/BUILD.gn
File crypto/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/1/crypto/BUILD.gn#newcode8
crypto/BUILD.gn:8: component("crypto") {
On 2015/08/27 23:28:00, Sergey Ulanov wrote:
> This looks like a big change, but I just moved the component out of the "if
> (is_nacl)" and added nacl_io dependency. 

Acknowledged.

https://codereview.chromium.org/1312463005/diff/1/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/1/net/BUILD.gn#newcode115
net/BUILD.gn:115: } else if (!is_nacl) {
This logic is somewhat hard to follow. I think it might make more sense to wrap
the entire thing (or perhaps feature-by-feature?) in an if (!is_nacl), since
this is all pertaining to random addons that are not in the core NaCl subset.

(Arguably we should be splitting //net up somewhat into two libraries. One's the
core socket stuff that NaCl needs and the other's the higher-level bits. But
that's an idle thought and probably not something to do in this CL. I haven't
thought about it any.)

https://codereview.chromium.org/1312463005/diff/1/net/BUILD.gn#newcode369
net/BUILD.gn:369: } else if (use_openssl_certs) {
I believe this breaks the GN Linux build. This should be use_openssl.
use_openssl_certs and use_openssl are semi-orthogonal. (At this point the only
case where use_openssl isn't true is iOS, although the !use_openssl NSS build is
still around in case we need to roll back. Possibly we should just delete now
that we've branched though, I dunno.)

https://codereview.chromium.org/1312463005/diff/1/net/BUILD.gn#newcode537
net/BUILD.gn:537: defines += [ "USE_OPENSSL_CERTS=1" ]
Instead tweak the definition of use_openssl_certs in build/config/crypto.gni.

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi
File net/net.gypi (left):

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi#oldcode160
net/net.gypi:160: 'socket/ssl_client_socket_pool.h',
Why were these changes needed? (I certainly believe that you don't need these
files. Just not what it has to do with GN. Does some stricter checking somewhere
cause problems?)

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi#oldcode361
net/net.gypi:361: 'quic/quic_reliable_client_stream.h',
Someone from QUIC should probably review this. I'm not clear on how subsetting
QUIC works. I'm guessing you want quic/p2p but don't care about anything
implementing SPDY things?

+rch

[Sergey Ulanov, 2015-08-31 21:59:28]

Patchset #2 (id:20001) has been deleted

[Sergey Ulanov, 2015-08-31 21:59:33]

https://codereview.chromium.org/1312463005/diff/1/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/1/net/BUILD.gn#newcode115
net/BUILD.gn:115: } else if (!is_nacl) {
On 2015/08/28 17:08:27, David Benjamin wrote:
> This logic is somewhat hard to follow. I think it might make more sense to
wrap
> the entire thing (or perhaps feature-by-feature?) in an if (!is_nacl), since
> this is all pertaining to random addons that are not in the core NaCl subset.
> 

Done.

> (Arguably we should be splitting //net up somewhat into two libraries. One's
the
> core socket stuff that NaCl needs and the other's the higher-level bits. But
> that's an idle thought and probably not something to do in this CL. I haven't
> thought about it any.)

https://codereview.chromium.org/1312463005/diff/1/net/BUILD.gn#newcode369
net/BUILD.gn:369: } else if (use_openssl_certs) {
On 2015/08/28 17:08:27, David Benjamin wrote:
> I believe this breaks the GN Linux build. This should be use_openssl.
> use_openssl_certs and use_openssl are semi-orthogonal. (At this point the only
> case where use_openssl isn't true is iOS, although the !use_openssl NSS build
is
> still around in case we need to roll back. Possibly we should just delete now
> that we've branched though, I dunno.)

I'm not sure why I changed this line. Reverted now.

https://codereview.chromium.org/1312463005/diff/1/net/BUILD.gn#newcode537
net/BUILD.gn:537: defines += [ "USE_OPENSSL_CERTS=1" ]
On 2015/08/28 17:08:27, David Benjamin wrote:
> Instead tweak the definition of use_openssl_certs in build/config/crypto.gni.

Done.

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi
File net/net.gypi (left):

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi#oldcode160
net/net.gypi:160: 'socket/ssl_client_socket_pool.h',
On 2015/08/28 17:08:27, David Benjamin wrote:
> Why were these changes needed? (I certainly believe that you don't need these
> files. Just not what it has to do with GN. Does some stricter checking
somewhere
> cause problems?)

The files I moved here should not be part of net_nacl_common_sources because
they have dependencies on files that are not on this list. With GYP the lib was
compiled to .a archive, and these unmet dependency were ignored when linking.
With GN src/net is linked as bunch of .o files without .a, so now it tries to
resolve all symbols in this files and fails to link them.

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi#oldcode361
net/net.gypi:361: 'quic/quic_reliable_client_stream.h',
On 2015/08/28 17:08:27, David Benjamin wrote:
> Someone from QUIC should probably review this. I'm not clear on how subsetting
> QUIC works. I'm guessing you want quic/p2p but don't care about anything
> implementing SPDY things?

That's right. We need to avoid all SPDY dependencies because they pull bunch of
other stuff that we don't need, e.g. zlib.

> 
> +rch

[davidben, 2015-08-31 23:11:06]

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi
File net/net.gypi (left):

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi#oldcode160
net/net.gypi:160: 'socket/ssl_client_socket_pool.h',
On 2015/08/31 21:59:33, Sergey Ulanov wrote:
> On 2015/08/28 17:08:27, David Benjamin wrote:
> > Why were these changes needed? (I certainly believe that you don't need
these
> > files. Just not what it has to do with GN. Does some stricter checking
> somewhere
> > cause problems?)
> 
> The files I moved here should not be part of net_nacl_common_sources because
> they have dependencies on files that are not on this list. With GYP the lib
was
> compiled to .a archive, and these unmet dependency were ignored when linking.
> With GN src/net is linked as bunch of .o files without .a, so now it tries to
> resolve all symbols in this files and fails to link them. 

Gotcha. Thanks for clarifying.

https://codereview.chromium.org/1312463005/diff/40001/build/config/crypto.gni
File build/config/crypto.gni (right):

https://codereview.chromium.org/1312463005/diff/40001/build/config/crypto.gni...
build/config/crypto.gni:25: # on NSS.
Let's change this to:

True when we're using OpenSSL for representing certificates. When targeting
Android, the platform certificate library is used for certificate verification.
On NaCl, verification isn't supported. Otherwise, OpenSSL is used for
certificate verification, but this configuration is unsupported.

(I think I wrote that comment without realizing the PNaCl target existed.)

I really should just ditch the use_openssl_certs Linux port and disentangle some
of this. We are never going to ship anything based on that code ever. It's grown
organically and is kind of a mess.

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn#newcode111
net/BUILD.gn:111: "//url",
I think you want to just omit //url. Judging from net_nacl.gyp, net_nacl does
depend on //url, but there's just no need to list it twice. (It's actually not a
public dependency in gyp, but it is here so I guess we can leave that.)

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn#newcode289
net/BUILD.gn:289: "cert/test_root_certs_openssl.cc",
What happened to:

base/openssl_private_key_store.h
base/openssl_private_key_store_memory.h
base/cert_database_openssl.cc
base/x509_certificate_openssl.cc
ssl/openssl_client_key_store.h
ssl/openssl_client_key_store.cc

Please run try bots. I don't think this would have built. (Or it might have on
accident.)

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn#newcode299
net/BUILD.gn:299: "cert/test_root_certs_openssl.cc",
What happened to:

base/openssl_private_key_store_memory.cc
cert/cert_database_openssl.cc

[garykac, 2015-08-31 23:27:10]

lgtm

https://codereview.chromium.org/1312463005/diff/40001/remoting/client/BUILD.gn
File remoting/client/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/remoting/client/BUILD.g...
remoting/client/BUILD.gn:8: # Disabled the source filters because there are _mac
files that need to
Then shouldn't the source files be renamed?  I wouldn't expect a _mac file to be
used by any non-mac builds.

https://codereview.chromium.org/1312463005/diff/40001/remoting/webapp/BUILD.gn
File remoting/webapp/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/remoting/webapp/BUILD.g...
remoting/webapp/BUILD.gn:35: group("webapp") {
Why expand this out as part of this CL?  Previously all the CRD/AR code was in
build_template.gni, but this change splits where the HTML files are built.

[Sergey Ulanov, 2015-09-01 00:06:46]

https://codereview.chromium.org/1312463005/diff/40001/build/config/crypto.gni
File build/config/crypto.gni (right):

https://codereview.chromium.org/1312463005/diff/40001/build/config/crypto.gni...
build/config/crypto.gni:25: # on NSS.
On 2015/08/31 23:11:06, David Benjamin wrote:
> Let's change this to:
> 
> True when we're using OpenSSL for representing certificates. When targeting
> Android, the platform certificate library is used for certificate
verification.
> On NaCl, verification isn't supported. Otherwise, OpenSSL is used for
> certificate verification, but this configuration is unsupported.
> 
> (I think I wrote that comment without realizing the PNaCl target existed.)
> 
> I really should just ditch the use_openssl_certs Linux port and disentangle
some
> of this. We are never going to ship anything based on that code ever. It's
grown
> organically and is kind of a mess.

Done.

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn#newcode111
net/BUILD.gn:111: "//url",
On 2015/08/31 23:11:06, David Benjamin wrote:
> I think you want to just omit //url. Judging from net_nacl.gyp, net_nacl does
> depend on //url, but there's just no need to list it twice. (It's actually not
a
> public dependency in gyp, but it is here so I guess we can leave that.)

this dep is added in !is_nacl only.

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn#newcode289
net/BUILD.gn:289: "cert/test_root_certs_openssl.cc",
On 2015/08/31 23:11:06, David Benjamin wrote:
> What happened to:
> 
> base/openssl_private_key_store.h
> base/openssl_private_key_store_memory.h
> base/cert_database_openssl.cc
> base/x509_certificate_openssl.cc
> ssl/openssl_client_key_store.h
> ssl/openssl_client_key_store.cc

Yes, these files should still be in this list - removed them by mistake.

> 
> Please run try bots. I don't think this would have built. (Or it might have on
> accident.)

Before I can try this changed I still need to land and roll a fix in webrtc:
https://codereview.chromium.org/1323453003/

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn#newcode299
net/BUILD.gn:299: "cert/test_root_certs_openssl.cc",
On 2015/08/31 23:11:06, David Benjamin wrote:
> What happened to:
> 
> base/openssl_private_key_store_memory.cc
> cert/cert_database_openssl.cc

They are back now.

https://codereview.chromium.org/1312463005/diff/40001/remoting/client/BUILD.gn
File remoting/client/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/remoting/client/BUILD.g...
remoting/client/BUILD.gn:8: # Disabled the source filters because there are _mac
files that need to
On 2015/08/31 23:27:10, garykac wrote:
> Then shouldn't the source files be renamed?  I wouldn't expect a _mac file to
be
> used by any non-mac builds.

This is for normalizing_input_filter_mac - it's a mac-specific code, but we run
the same plugin on all platforms (because PNaCl build is cross-platform) and
decide in runtime if that filter needs to be enabled. Since it's mac-specific it
has Mac suffix, but yes, it can be renamed. Do you have suggestions for a
different name?
I'd prefer renaming it in a separate CL.

https://codereview.chromium.org/1312463005/diff/40001/remoting/webapp/BUILD.gn
File remoting/webapp/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/remoting/webapp/BUILD.g...
remoting/webapp/BUILD.gn:35: group("webapp") {
On 2015/08/31 23:27:10, garykac wrote:
> Why expand this out as part of this CL?  Previously all the CRD/AR code was in
> build_template.gni, but this change splits where the HTML files are built.

This was the only place where the desktop_remoting_webapp() template was applied
and we will need to cleanup build_template.gni anyway, so I didn't see much
value in keeping the template. If you disagree I can add it back and add
client/plugin dependency in the template.

[Sergey Ulanov, 2015-09-01 00:07:59]

sergeyu@chromium.org changed reviewers:
+ dpranke@chromium.org

[Sergey Ulanov, 2015-09-01 00:08:00]

+dpranke@
Dirk, please approve the change in build/config/crypto.gni

[davidben, 2015-09-01 18:06:48]

lgtm with comment

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/net/BUILD.gn#newcode111
net/BUILD.gn:111: "//url",
On 2015/09/01 00:06:46, Sergey Ulanov wrote:
> On 2015/08/31 23:11:06, David Benjamin wrote:
> > I think you want to just omit //url. Judging from net_nacl.gyp, net_nacl
does
> > depend on //url, but there's just no need to list it twice. (It's actually
not
> a
> > public dependency in gyp, but it is here so I guess we can leave that.)
> 
> this dep is added in !is_nacl only.

It's also added for is_nacl in line 93. And in net_nacl.gyp [1]. I'm suggesting
remove this line because it seems to be redundant with line 93.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/net/net_nacl.gyp&l=29

[Dirk Pranke, 2015-09-01 19:04:27]

lgtm

[garykac, 2015-09-01 20:53:27]

https://codereview.chromium.org/1312463005/diff/40001/remoting/client/BUILD.gn
File remoting/client/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/remoting/client/BUILD.g...
remoting/client/BUILD.gn:8: # Disabled the source filters because there are _mac
files that need to
On 2015/09/01 00:06:46, Sergey Ulanov wrote:
> On 2015/08/31 23:27:10, garykac wrote:
> > Then shouldn't the source files be renamed?  I wouldn't expect a _mac file
to
> be
> > used by any non-mac builds.
> 
> This is for normalizing_input_filter_mac - it's a mac-specific code, but we
run
> the same plugin on all platforms (because PNaCl build is cross-platform) and
> decide in runtime if that filter needs to be enabled. Since it's mac-specific
it
> has Mac suffix, but yes, it can be renamed. Do you have suggestions for a
> different name?
> I'd prefer renaming it in a separate CL.

Yes, a name change is more appropriate in a separate cl.

Perhaps _pnacl? or _mac_pnacl?

https://codereview.chromium.org/1312463005/diff/40001/remoting/webapp/BUILD.gn
File remoting/webapp/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/remoting/webapp/BUILD.g...
remoting/webapp/BUILD.gn:35: group("webapp") {
On 2015/09/01 00:06:46, Sergey Ulanov wrote:
> On 2015/08/31 23:27:10, garykac wrote:
> > Why expand this out as part of this CL?  Previously all the CRD/AR code was
in
> > build_template.gni, but this change splits where the HTML files are built.
> 
> This was the only place where the desktop_remoting_webapp() template was
applied
> and we will need to cleanup build_template.gni anyway, so I didn't see much
> value in keeping the template. If you disagree I can add it back and add
> client/plugin dependency in the template.

Even if we need to do this at some point, it doesn't seem like it belongs in
this cl. It clutters the diff and hides any changes that relate to what is in
the cl's description.

[Ryan Hamilton, 2015-09-02 19:22:58]

lgtm

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi
File net/net.gypi (left):

https://codereview.chromium.org/1312463005/diff/1/net/net.gypi#oldcode361
net/net.gypi:361: 'quic/quic_reliable_client_stream.h',
On 2015/08/31 21:59:33, Sergey Ulanov wrote:
> On 2015/08/28 17:08:27, David Benjamin wrote:
> > Someone from QUIC should probably review this. I'm not clear on how
subsetting
> > QUIC works. I'm guessing you want quic/p2p but don't care about anything
> > implementing SPDY things?
> 
> That's right. We need to avoid all SPDY dependencies because they pull bunch
of
> other stuff that we don't need, e.g. zlib.
> 
> > 
> > +rch
> 

Makes sense to me.

[Sergey Ulanov, 2015-09-03 00:07:15]

https://codereview.chromium.org/1312463005/diff/40001/remoting/webapp/BUILD.gn
File remoting/webapp/BUILD.gn (right):

https://codereview.chromium.org/1312463005/diff/40001/remoting/webapp/BUILD.g...
remoting/webapp/BUILD.gn:35: group("webapp") {
On 2015/09/01 20:53:27, garykac wrote:
> On 2015/09/01 00:06:46, Sergey Ulanov wrote:
> > On 2015/08/31 23:27:10, garykac wrote:
> > > Why expand this out as part of this CL?  Previously all the CRD/AR code
was
> in
> > > build_template.gni, but this change splits where the HTML files are built.
> > 
> > This was the only place where the desktop_remoting_webapp() template was
> applied
> > and we will need to cleanup build_template.gni anyway, so I didn't see much
> > value in keeping the template. If you disagree I can add it back and add
> > client/plugin dependency in the template.
> 
> Even if we need to do this at some point, it doesn't seem like it belongs in
> this cl. It clutters the diff and hides any changes that relate to what is in
> the cl's description.

ok, returned the template back

[garykac, 2015-09-03 01:07:12]

lgtm

[Sergey Ulanov, 2015-09-03 23:29:22]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-09-03 23:29:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, davidben@chromium.org, rch@chromium.org,
garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/1312463005/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-09-03 23:29:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312463005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312463005/100001

[commit-bot: I haz the power, 2015-09-03 23:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 23:34:21]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Sergey Ulanov, 2015-09-04 00:38:28]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-09-04 00:38:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, davidben@chromium.org, garykac@chromium.org,
rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1312463005/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-09-04 00:38:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312463005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312463005/120001

[commit-bot: I haz the power, 2015-09-04 01:23:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 01:23:03]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ryan Hamilton, 2015-09-10 23:20:00]

Is this CL still active?

[Sergey Ulanov, 2015-09-10 23:23:27]

On 2015/09/10 23:20:00, Ryan Hamilton wrote:
> Is this CL still active?

Yes, but it's blocked on https://codereview.chromium.org/1321253011/ .
Problem is that this CL adds dependency on boringssl in //crypto, but boringssl
currently doesn't compile for NaCl (only for PNaCl). We don't really need
//crypto for NaCl - it was used in //ipc just for crypto::RandBytes().

[Sergey Ulanov, 2015-09-14 17:27:05]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-09-14 17:27:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, davidben@chromium.org, garykac@chromium.org,
rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1312463005/#ps140001
(title: " ")

[commit-bot: I haz the power, 2015-09-14 17:28:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312463005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312463005/140001

[commit-bot: I haz the power, 2015-09-14 17:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:31:56]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sergey Ulanov, 2015-09-14 19:03:43]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-09-14 19:03:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, davidben@chromium.org, garykac@chromium.org,
rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1312463005/#ps160001
(title: " ")

[commit-bot: I haz the power, 2015-09-14 19:04:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312463005/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312463005/160001

[commit-bot: I haz the power, 2015-09-14 20:08:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 20:08:59]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sergey Ulanov, 2015-09-14 21:31:35]

The CQ bit was checked by sergeyu@chromium.org

[Sergey Ulanov, 2015-09-14 21:31:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, davidben@chromium.org, garykac@chromium.org,
rch@chromium.org
Link to the patchset: https://codereview.chromium.org/1312463005/#ps180001
(title: " ")

[commit-bot: I haz the power, 2015-09-14 21:32:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312463005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312463005/180001

[commit-bot: I haz the power, 2015-09-14 23:03:40]

Committed patchset #9 (id:180001)

[commit-bot: I haz the power, 2015-09-14 23:04:28]

Patchset 9 (id:??) landed as
https://crrev.com/99d83f9b9121d659cdbf259ec9f71f8d1f090100
Cr-Commit-Position: refs/heads/master@{#348752}

[commit-bot: I haz the power, 2015-09-23 12:38:31]

Patchset 9 (id:??) landed as
https://crrev.com/99d83f9b9121d659cdbf259ec9f71f8d1f090100
Cr-Commit-Position: refs/heads/master@{#348752}