Turn VariationsService::GetVariationsServerURL into instance method

Turn VariationsService::GetVariationsServerURL into instance method

This will allow for followup work that uses |client_| within that
method.

BUG=516678
TBR=bartfab

Committed: https://crrev.com/642578a171c7acee3de6b514bf2738fcb0339aac
Cr-Commit-Position: refs/heads/master@{#346111}

[blundell, 2015-08-27 19:18:12]

blundell@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-08-27 19:21:33]

LGTM assuming bots are happy

Please associate with a crbug

[blundell, 2015-08-28 08:35:04]

On 2015/08/27 19:21:33, Alexei Svitkine wrote:
> LGTM assuming bots are happy
> 
> Please associate with a crbug

Added bugref.

[blundell, 2015-08-28 09:54:10]

blundell@chromium.org changed reviewers:
+ bartfab@chromium.org

[blundell, 2015-08-28 09:54:30]

TBR=bartfab for //chrome/browser/policy and //chrome/browser/chromeos/policy

[blundell, 2015-08-28 09:54:35]

The CQ bit was checked by blundell@chromium.org

[blundell, 2015-08-28 09:54:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1312423003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2015-08-28 09:54:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312423003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312423003/20001

[commit-bot: I haz the power, 2015-08-28 09:59:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-28 10:00:00]

Patchset 2 (id:??) landed as
https://crrev.com/642578a171c7acee3de6b514bf2738fcb0339aac
Cr-Commit-Position: refs/heads/master@{#346111}

[blundell, 2015-08-28 14:21:00]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1320503005/ by blundell@chromium.org.

The reason for reverting is: It turns out that this change is actually not safe
as written: g_browser_process->variations_service() returns null in non-official
builds unless a default variations server URL is set on the command line. The
reason the patch did not fail is because the method being called was (a) not
virtual and (b) didn't use any state of the object..

[bartfab (slow), 2015-08-29 07:25:09]

chrome/browser/policy/*
chrome/browser/chromeos/policy/*

LGTM

Sorry for the delay. I was traveling.

https://codereview.chromium.org/1312423003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc
(right):

https://codereview.chromium.org/1312423003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc:46:
g_browser_process->variations_service()->GetVariationsServerURL(
Nit: #include "chrome/browser/browser_process.h"

https://codereview.chromium.org/1312423003/diff/20001/chrome/browser/policy/p...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/1312423003/diff/20001/chrome/browser/policy/p...
chrome/browser/policy/policy_browsertest.cc:3778:
g_browser_process->variations_service()->GetVariationsServerURL(
Nit: #include "chrome/browser/browser_process.h"