chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc - Issue 1312423003: Turn VariationsService::GetVariationsServerURL into instance method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc

Issue 1312423003: Turn VariationsService::GetVariationsServerURL into instance method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc

diff --git a/chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc b/chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc

index a997ec94fce13fa7dbe37d9cee4f906880d7746a..603a98106544da74d71c2adbcb414eca63fd644a 100644

--- a/chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc

+++ b/chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc

@@ -42,8 +42,9 @@ IN_PROC_BROWSER_TEST_F(VariationsServiceDevicePolicyTest, VariationsURLValid) {

GetDefaultVariationsServerURLForTesting();

// Device policy has updated the cros settings.

- const GURL url = chrome_variations::VariationsService::GetVariationsServerURL(

- g_browser_process->local_state(), std::string());

+ const GURL url =

+ g_browser_process->variations_service()->GetVariationsServerURL(

bartfab (slow) 2015/08/29 07:25:09 Nit: #include "chrome/browser/browser_process.h"

+ g_browser_process->local_state(), std::string());

EXPECT_TRUE(base::StartsWith(url.spec(), default_variations_url,

base::CompareCase::SENSITIVE));

std::string value;

« no previous file with comments | « no previous file | chrome/browser/metrics/variations/variations_service.h » ('j') | chrome/browser/policy/policy_browsertest.cc » ('J')