Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 1312343004: [ServiceWorker] Use appopriate type parameters for WebCallbacks (1/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 1312343004: [ServiceWorker] Use appopriate type parameters for WebCallbacks (1/3) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | public/platform/modules/serviceworker/WebServiceWorkerProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerRegistration.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/Source/modules/serviceworkers/ServiceWorkerRegistration.h

index 737ff677c1aa7fb24a30eafa071754beb781d81f..c03de8fe6321c28bcde99e9a9eccc43f0ac51f43 100644

--- a/Source/modules/serviceworkers/ServiceWorkerRegistration.h

+++ b/Source/modules/serviceworkers/ServiceWorkerRegistration.h

@@ -83,11 +83,11 @@ private:

class ServiceWorkerRegistrationArray {

STATIC_ONLY(ServiceWorkerRegistrationArray);

public:

- static HeapVector<Member<ServiceWorkerRegistration>> take(ScriptPromiseResolver* resolver, PassOwnPtr<WebVector<WebServiceWorkerRegistration*>> webServiceWorkerRegistrations)

+ static HeapVector<Member<ServiceWorkerRegistration>> take(ScriptPromiseResolver* resolver, Vector<OwnPtr<WebServiceWorkerRegistration>>* webServiceWorkerRegistrations)

{

HeapVector<Member<ServiceWorkerRegistration>> registrations;

- for (WebServiceWorkerRegistration* registration : *webServiceWorkerRegistrations)

- registrations.append(ServiceWorkerRegistration::create(resolver->executionContext(), adoptPtr(registration)));

+ for (auto& registration : *webServiceWorkerRegistrations)

+ registrations.append(ServiceWorkerRegistration::create(resolver->executionContext(), registration.release()));

return registrations;

}

};