Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 131233007: Cast: Clean up injection of transport into PacedPacketSender (Closed)

Created:
6 years, 10 months ago by hubbe
Modified:
6 years, 10 months ago
Reviewers:
mikhal1, mikhal
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: Clean up injection of transport into PacedPacketSender Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248558

Patch Set 1 #

Patch Set 2 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -85 lines) Patch
M media/cast/audio_sender/audio_sender_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/cast_receiver_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cast/rtcp/rtcp_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/transport/cast_transport_sender_impl.h View 2 chunks +6 lines, -3 lines 0 comments Download
M media/cast/transport/cast_transport_sender_impl.cc View 3 chunks +16 lines, -10 lines 0 comments Download
M media/cast/transport/pacing/paced_sender.h View 2 chunks +4 lines, -15 lines 0 comments Download
M media/cast/transport/pacing/paced_sender.cc View 4 chunks +4 lines, -33 lines 0 comments Download
M media/cast/transport/pacing/paced_sender_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hubbe
6 years, 10 months ago (2014-01-31 18:03:04 UTC) #1
hubbe
On 2014/01/31 18:03:04, hubbe wrote: Ping?
6 years, 10 months ago (2014-02-03 17:31:50 UTC) #2
mikhal1
lgtm
6 years, 10 months ago (2014-02-03 17:42:28 UTC) #3
hubbe
The CQ bit was checked by hubbe@chromium.org
6 years, 10 months ago (2014-02-03 17:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/131233007/130001
6 years, 10 months ago (2014-02-03 17:46:46 UTC) #5
commit-bot: I haz the power
Change committed as 248558
6 years, 10 months ago (2014-02-03 19:53:46 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:53:48 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 19:53:48 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698