Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: media/cast/transport/pacing/paced_sender.h

Issue 131233007: Cast: Clean up injection of transport into PacedPacketSender (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merged Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/transport/cast_transport_sender_impl.cc ('k') | media/cast/transport/pacing/paced_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/transport/pacing/paced_sender.h
diff --git a/media/cast/transport/pacing/paced_sender.h b/media/cast/transport/pacing/paced_sender.h
index d062eb556c187619d8fe8b1e8e104554b215eb84..2f3428a834137fa24c4f560dfd29c36162667ac9 100644
--- a/media/cast/transport/pacing/paced_sender.h
+++ b/media/cast/transport/pacing/paced_sender.h
@@ -40,27 +40,19 @@ class PacedSender : public PacedPacketSender,
public base::NonThreadSafe,
public base::SupportsWeakPtr<PacedSender> {
public:
- // The |external_transport| should only be used by the Cast receiver and for
- // testing.
PacedSender(base::TickClock* clock,
- const CastTransportConfig* const config,
- PacketSender* external_transport,
- const scoped_refptr<base::TaskRunner>& transport_task_runner,
- const CastTransportStatusCallback& status_callback);
+ PacketSender* transport,
+ const scoped_refptr<base::TaskRunner>& transport_task_runner);
virtual ~PacedSender();
// PacedPacketSender implementation.
- virtual void SetPacketReceiver(const PacketReceiverCallback& packet_receiver);
-
virtual bool SendPackets(const PacketList& packets) OVERRIDE;
virtual bool ResendPackets(const PacketList& packets) OVERRIDE;
virtual bool SendRtcpPacket(const Packet& packet) OVERRIDE;
- void InsertFakeTransportForTesting(PacketSender* fake_transport);
-
protected:
// Schedule a delayed task on the main cast thread when it's time to send the
// next packet burst.
@@ -73,17 +65,14 @@ class PacedSender : public PacedPacketSender,
bool SendPacketsToTransport(const PacketList& packets,
PacketList* packets_not_sent);
- // Actually sends the packets to the transport. When set, packets will be sent
- // to the external transport.
+ // Actually sends the packets to the transport.
bool TransmitPackets(const PacketList& packets);
void SendStoredPackets();
void UpdateBurstSize(size_t num_of_packets);
// Not owned by this class.
base::TickClock* const clock_;
- scoped_ptr<UdpTransport> transport_;
- PacketSender* external_transport_; // Not owned by this class.
- const CastTransportConfig* const config_; // Not owned by this class.
+ PacketSender* transport_; // Not owned by this class.
scoped_refptr<base::TaskRunner> transport_task_runner_;
size_t burst_size_;
« no previous file with comments | « media/cast/transport/cast_transport_sender_impl.cc ('k') | media/cast/transport/pacing/paced_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698