Flash: Don't lose a reference to the Graphics3D from the VideoDecoder.

webkit/plugins/ppapi/ppb_video_decoder_impl.cc

Index: webkit/plugins/ppapi/ppb_video_decoder_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_video_decoder_impl.cc b/webkit/plugins/ppapi/ppb_video_decoder_impl.cc
index f1f7ed216d6e73ceb62914228796431652cfa0c6..c6bb1ea8fa75f2902c2dc12818a030aea9fa93e5 100644
--- a/webkit/plugins/ppapi/ppb_video_decoder_impl.cc
+++ b/webkit/plugins/ppapi/ppb_video_decoder_impl.cc
@@ -206,12 +206,13 @@ int32_t PPB_VideoDecoder_Impl::Reset(scoped_refptr<TrackedCallback> callback) {
 }
 
 void PPB_VideoDecoder_Impl::Destroy() {
+  FlushCommandBuffer();
+  PPB_VideoDecoder_Shared::Destroy();

[piman, 2013/03/27 22:48:31]

Because this will release the context, I'd be somewhat more comfortable if we
still did it after the platform_video_decoder_.release()->Destroy()

e.g:
FlushCommandBuffer();
if (platform_video_decoder_.get())
  platform_video_decoder_.release()->Destroy();
PPB_VideoDecoder_Shared::Destroy();
ppp_videodecoder_ = NULL;

[danakj, 2013/03/27 22:54:52]

Oh, sounds good! Done.

+
   if (!platform_video_decoder_.get())
     return;
 
-  FlushCommandBuffer();
   platform_video_decoder_.release()->Destroy();
-  ::ppapi::PPB_VideoDecoder_Shared::Destroy();
   ppp_videodecoder_ = NULL;
 }