Flash: Don't lose a reference to the Graphics3D from the VideoDecoder.

webkit/plugins/ppapi/ppb_video_decoder_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_video_decoder_impl.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 188 matching lines @@
 
   if (!SetResetCallback(callback))
     return PP_ERROR_INPROGRESS;
 
   FlushCommandBuffer();
   platform_video_decoder_->Reset();
   return PP_OK_COMPLETIONPENDING;
 }
 
 void PPB_VideoDecoder_Impl::Destroy() {
+  FlushCommandBuffer();
+  PPB_VideoDecoder_Shared::Destroy();

[piman, 2013/03/27 22:48:31]

Because this will release the context, I'd be somewhat more comfortable if we
still did it after the platform_video_decoder_.release()->Destroy()

e.g:
FlushCommandBuffer();
if (platform_video_decoder_.get())
  platform_video_decoder_.release()->Destroy();
PPB_VideoDecoder_Shared::Destroy();
ppp_videodecoder_ = NULL;

[danakj, 2013/03/27 22:54:52]

Oh, sounds good! Done.

+
   if (!platform_video_decoder_.get())
     return;
 
-  FlushCommandBuffer();
   platform_video_decoder_.release()->Destroy();
-  ::ppapi::PPB_VideoDecoder_Shared::Destroy();
   ppp_videodecoder_ = NULL;
 }
 
 void PPB_VideoDecoder_Impl::ProvidePictureBuffers(
     uint32 requested_num_of_buffers,
     const gfx::Size& dimensions,
     uint32 texture_target) {
   if (!ppp_videodecoder_)
     return;
 
@@ skipping 44 matching lines @@
 void PPB_VideoDecoder_Impl::NotifyFlushDone() {
   RunFlushCallback(PP_OK);
 }
 
 void PPB_VideoDecoder_Impl::NotifyInitializeDone() {
   NOTREACHED() << "PlatformVideoDecoder::Initialize() is synchronous!";
 }
 
 }  // namespace ppapi
 }  // namespace webkit