Flash: Don't lose a reference to the Graphics3D from the VideoDecoder.

webkit/plugins/ppapi/ppb_video_decoder_impl.cc

Index: webkit/plugins/ppapi/ppb_video_decoder_impl.cc
diff --git a/webkit/plugins/ppapi/ppb_video_decoder_impl.cc b/webkit/plugins/ppapi/ppb_video_decoder_impl.cc
index f1f7ed216d6e73ceb62914228796431652cfa0c6..189ef8abe27b6ed0ab631d5554b7291a98acdd89 100644
--- a/webkit/plugins/ppapi/ppb_video_decoder_impl.cc
+++ b/webkit/plugins/ppapi/ppb_video_decoder_impl.cc
@@ -206,13 +206,12 @@ int32_t PPB_VideoDecoder_Impl::Reset(scoped_refptr<TrackedCallback> callback) {
 }
 
 void PPB_VideoDecoder_Impl::Destroy() {
-  if (!platform_video_decoder_.get())
-    return;
+  if (platform_video_decoder_)
+    platform_video_decoder_.release()->Destroy();
+  ppp_videodecoder_ = NULL;
 
   FlushCommandBuffer();

[piman, 2013/03/27 23:37:43]

I think this still needs to happen before the
platform_video_decoder_.release()->Destroy() (that's what guarantees ordering
between the command buffer and the video decoder IPCs)

[danakj, 2013/03/27 23:42:06]

Ok i was kinda wondering about that one. Thanks. Done.

-  platform_video_decoder_.release()->Destroy();
   ::ppapi::PPB_VideoDecoder_Shared::Destroy();
-  ppp_videodecoder_ = NULL;
 }
 
 void PPB_VideoDecoder_Impl::ProvidePictureBuffers(