Flash: Don't lose a reference to the Graphics3D from the VideoDecoder.

webkit/plugins/ppapi/ppb_video_decoder_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppb_video_decoder_impl.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/message_loop.h"
@@ skipping 188 matching lines @@
 
   if (!SetResetCallback(callback))
     return PP_ERROR_INPROGRESS;
 
   FlushCommandBuffer();
   platform_video_decoder_->Reset();
   return PP_OK_COMPLETIONPENDING;
 }
 
 void PPB_VideoDecoder_Impl::Destroy() {
-  if (!platform_video_decoder_.get())
-    return;
+  if (platform_video_decoder_)
+    platform_video_decoder_.release()->Destroy();
+  ppp_videodecoder_ = NULL;
 
   FlushCommandBuffer();

[piman, 2013/03/27 23:37:43]

I think this still needs to happen before the
platform_video_decoder_.release()->Destroy() (that's what guarantees ordering
between the command buffer and the video decoder IPCs)

[danakj, 2013/03/27 23:42:06]

Ok i was kinda wondering about that one. Thanks. Done.

-  platform_video_decoder_.release()->Destroy();
   ::ppapi::PPB_VideoDecoder_Shared::Destroy();
-  ppp_videodecoder_ = NULL;
 }
 
 void PPB_VideoDecoder_Impl::ProvidePictureBuffers(
     uint32 requested_num_of_buffers,
     const gfx::Size& dimensions,
     uint32 texture_target) {
   if (!ppp_videodecoder_)
     return;
 
   PP_Size out_dim = PP_MakeSize(dimensions.width(), dimensions.height());
@@ skipping 43 matching lines @@
 void PPB_VideoDecoder_Impl::NotifyFlushDone() {
   RunFlushCallback(PP_OK);
 }
 
 void PPB_VideoDecoder_Impl::NotifyInitializeDone() {
   NOTREACHED() << "PlatformVideoDecoder::Initialize() is synchronous!";
 }
 
 }  // namespace ppapi
 }  // namespace webkit