Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 131223003: Track intruding and overhanging floats (Closed)

Created:
6 years, 11 months ago by Bem Jones-Bey (adobe)
Modified:
6 years, 11 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Visibility:
Public.

Description

Track intruding and overhanging floats Keep track of which floats in the floating object list are intruding or overhanging so that they can be removed from the list before the container is and it's children are destoryed. This makes it impossible to access an already destroyed float renderer when detaching the tree. In addition, use the new knowledge about intruding and overhanging floats to only copy the FloatingObject entries for contained floats in moveAllChildrenIncludingFloatsTo. This also fixes a bug in FloatingObject::unsafeClone, it shouldn't copy the originatingLine, because that allows breaking the rule that the renderer for the line must be the same as the renderer that contains the FloatingObject instance. BUG=245727 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165002

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/block/float/float-selection-delete-crash.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fast/block/float/float-selection-delete-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/FloatingObjects.h View 4 chunks +7 lines, -0 lines 0 comments Download
M Source/core/rendering/FloatingObjects.cpp View 5 chunks +29 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bem Jones-Bey (adobe)
This seems to have a very small perf impact, but also fixes the issue with ...
6 years, 11 months ago (2014-01-12 06:17:02 UTC) #1
leviw_travelin_and_unemployed
LGTM!
6 years, 11 months ago (2014-01-13 19:35:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bjonesbe@adobe.com/131223003/80001
6 years, 11 months ago (2014-01-13 19:41:51 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 21:12:48 UTC) #4
Message was sent while issue was closed.
Change committed as 165002

Powered by Google App Engine
This is Rietveld 408576698