Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: content/browser/frame_host/navigation_handle_impl.h

Issue 1312213010: PageLoadMetrics renderer and browser implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Instrumented NavigationHandle for IsSamePage, fixed broken logic and tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_handle_impl.h
diff --git a/content/browser/frame_host/navigation_handle_impl.h b/content/browser/frame_host/navigation_handle_impl.h
index 33e51ddab278cf281b89fe998d32159acc2210b0..3b84ca25e60b2d7e2dd47aee8e9f5153bdb65984 100644
--- a/content/browser/frame_host/navigation_handle_impl.h
+++ b/content/browser/frame_host/navigation_handle_impl.h
@@ -62,9 +62,14 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
const GURL& GetURL() const override;
net::Error GetNetErrorCode() const override;
bool IsInMainFrame() const override;
+ bool IsSamePage() const override;
bool HasCommittedDocument() const override;
bool HasCommittedErrorPage() const override;
+ void set_is_same_page(bool is_same_page) {
clamy 2015/09/08 13:25:58 Instead of a setter, I would rather have set_is_sa
Charlie Harrison 2015/09/08 23:05:15 Done.
+ is_same_page_ = is_same_page;
+ }
+
void set_net_error_code(net::Error net_error_code) {
net_error_code_ = net_error_code;
}
@@ -104,6 +109,9 @@ class CONTENT_EXPORT NavigationHandleImpl : public NavigationHandle {
State state_;
const bool is_main_frame_;
+ // Whether the navigation resulted in a same-page navigation
clamy 2015/09/08 13:25:58 I would replace with "Whether the navigation happe
Charlie Harrison 2015/09/08 23:05:16 Done.
+ bool is_same_page_;
+
// Whether the navigation is in the middle of a transfer. Set to false when
// the DidStartProvisionalLoad is received from the new renderer.
bool is_transferring_;

Powered by Google App Engine
This is Rietveld 408576698