PageLoadMetrics renderer and browser implementation.

content/browser/frame_host/navigation_handle_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_
 
 #include "content/public/browser/navigation_handle.h"
 
 #include "base/macros.h"
@@ skipping 44 matching lines @@
   static scoped_ptr<NavigationHandleImpl> Create(const GURL& url,
                                                  const bool is_main_frame,
                                                  NavigatorDelegate* delegate);
 
   ~NavigationHandleImpl() override;
 
   // NavigationHandle implementation:
   const GURL& GetURL() const override;
   net::Error GetNetErrorCode() const override;
   bool IsInMainFrame() const override;
+  bool IsSamePage() const override;
   bool HasCommittedDocument() const override;
   bool HasCommittedErrorPage() const override;
 
+  void set_is_same_page(bool is_same_page) {

[clamy, 2015/09/08 13:25:58]

Instead of a setter, I would rather have set_is_same_page passed as a paremeter
to DidCommitNavigation and updated there.

[Charlie Harrison, 2015/09/08 23:05:15]

Done.

+    is_same_page_ = is_same_page;
+  }
+
   void set_net_error_code(net::Error net_error_code) {
     net_error_code_ = net_error_code;
   }
 
   // Returns whether the navigation is currently being transferred from one
   // RenderFrameHost to another. In particular, a DidStartProvisionalLoad IPC
   // for the navigation URL, received in the new RenderFrameHost, should not
   // indicate the start of a new navigation in that case.
   bool is_transferring() const { return is_transferring_; }
   void set_is_transferring(bool is_transferring) {
@@ skipping 19 matching lines @@
   NavigationHandleImpl(const GURL& url,
                        const bool is_main_frame,
                        NavigatorDelegate* delegate);
 
   // See NavigationHandle for a description of those member variables.
   GURL url_;
   net::Error net_error_code_;
   State state_;
   const bool is_main_frame_;
 
+  // Whether the navigation resulted in a same-page navigation

[clamy, 2015/09/08 13:25:58]

I would replace with "Whether the navigation happened in the same page."

[Charlie Harrison, 2015/09/08 23:05:16]

Done.

+  bool is_same_page_;
+
   // Whether the navigation is in the middle of a transfer. Set to false when
   // the DidStartProvisionalLoad is received from the new renderer.
   bool is_transferring_;
 
   // The delegate that should be notified about events related to this
   // navigation.
   NavigatorDelegate* delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationHandleImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_HANDLE_IMPL_H_