Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 1312213007: Don't explicitly tear down code range in cctest/test-alloc/CodeRange to avoid double-free. (Closed)

Created:
5 years, 3 months ago by Hannes Payer (out of office)
Modified:
5 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't explicitly tear down code range in cctest/test-alloc/CodeRange to avoid double-free. BUG=v8:4141 LOG=n R=mlippautz@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/9a3327adad3559ac540fc7957663c1d7e854909c

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/heap/spaces.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Hannes Payer (out of office)
5 years, 3 months ago (2015-08-26 08:12:58 UTC) #2
Michael Lippautz
Can we make src/heap/spaces.h:934 // Frees the range of virtual memory, and frees the data ...
5 years, 3 months ago (2015-08-26 08:15:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312213007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312213007/20001
5 years, 3 months ago (2015-08-26 08:16:00 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-08-26 08:16:02 UTC) #7
Hannes Payer (out of office)
done
5 years, 3 months ago (2015-08-26 08:18:18 UTC) #9
Michael Lippautz
lgtm
5 years, 3 months ago (2015-08-26 08:20:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312213007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312213007/40001
5 years, 3 months ago (2015-08-26 08:20:40 UTC) #12
Hannes Payer (out of office)
5 years, 3 months ago (2015-08-26 09:28:47 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9a3327adad3559ac540fc7957663c1d7e854909c (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698