Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: test/cctest/test-alloc.cc

Issue 1312213007: Don't explicitly tear down code range in cctest/test-alloc/CodeRange to avoid double-free. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 int index = Pseudorandom() % blocks.length(); 236 int index = Pseudorandom() % blocks.length();
237 code_range.FreeRawMemory(blocks[index].base, blocks[index].size); 237 code_range.FreeRawMemory(blocks[index].base, blocks[index].size);
238 current_allocated -= blocks[index].size; 238 current_allocated -= blocks[index].size;
239 if (index < blocks.length() - 1) { 239 if (index < blocks.length() - 1) {
240 blocks[index] = blocks.RemoveLast(); 240 blocks[index] = blocks.RemoveLast();
241 } else { 241 } else {
242 blocks.RemoveLast(); 242 blocks.RemoveLast();
243 } 243 }
244 } 244 }
245 } 245 }
246
247 code_range.TearDown();
248 } 246 }
OLDNEW
« no previous file with comments | « test/cctest/cctest.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698