LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html - Issue 1312213006: Remove MediaStream label, ended attributes and stop() method

Unified Diff: LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html

Issue 1312213006: Remove MediaStream label, ended attributes and stop() method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/mediastream/MediaStreamConstructor.html ('K') | « LayoutTests/fast/mediastream/MediaStreamConstructor-expected.txt ('k') | LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html

diff --git a/LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html b/LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html

index 31abbd43cf6b7af5cc41bf8297a475e324eecb9d..0779ddb3f8dac9bc6d09efab9ad36f9a55be00ce 100644

--- a/LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html

+++ b/LayoutTests/imported/web-platform-tests/mediacapture-streams/stream-api/mediastream/stream-ended.html

@@ -1,7 +1,7 @@

<!doctype html>

<html>

<head>

-<title>getUserMedia({video:true}) creates a stream with ended set to false</title>

+<title>getUserMedia({video:true}) creates a stream</title>

philipj_slow 2015/08/27 14:34:54 I'd like feedback from whoever wrote the test if t

shiva.jm 2015/08/28 04:40:23 Yes, right already other test cover these test. sh

tommi (sloooow) - chröme 2015/08/31 07:31:06 Seems to have been added here: https://chromium.go

philipj_slow 2015/08/31 14:34:28 Shiva, did you take a look at this and compare to

@@ -11,24 +11,19 @@

<p class="instructions" style="display:none">When prompted, accept to share your video stream.</p>

<h1 class="instructions" style="display:none">Description</h1>

<p class="instructions" style="display:none">This test checks that the MediaStream object returned by

-the success callback in getUserMedia has a ended set to false at start, and

-triggers "onended" when it is set to true.</p>

+the success callback in getUserMedia handles onended correctly.</p>

-var t = async_test("Tests that a MediaStream handles ended correctly", {timeout:10000});

+var t = async_test("Tests that a MediaStream handles onended correctly", {timeout:10000});

t.step(function () {

navigator.getUserMedia({video:true}, t.step_func(function (stream) {

- assert_true(!stream.ended, "the media stream starts with ended set to false");

stream.addEventListener("ended", t.step_func(function() {

- assert_true(stream.ended, "stream.ended now set to true");

t.done();

}), false);

- stream.ended = true;

- assert_true(!stream.ended, "stream.ended should remain false");

stream.getVideoTracks()[0].stop();

}), function (error) {});

});