content/browser/web_contents/web_contents_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.cc ('k') | content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_android.cc

diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc

index 0131bf997260b8095ea9637b96a5e35d36d1fd85..ff58da2f893e161c6e50ca56b66b12bc16f0087d 100644

--- a/content/browser/web_contents/web_contents_android.cc

+++ b/content/browser/web_contents/web_contents_android.cc

@@ -156,7 +156,7 @@ WebContents* WebContents::FromJavaWebContents(

// static

static void DestroyWebContents(JNIEnv* env,

- jclass clazz,

+ const JavaParamRef<jclass>& clazz,

jlong jweb_contents_android_ptr) {

WebContentsAndroid* web_contents_android =

reinterpret_cast<WebContentsAndroid*>(jweb_contents_android_ptr);

@@ -172,7 +172,7 @@ static void DestroyWebContents(JNIEnv* env,

// static

ScopedJavaLocalRef<jobject> FromNativePtr(JNIEnv* env,

- jclass clazz,

+ const JavaParamRef<jclass>& clazz,

jlong web_contents_ptr) {

WebContentsAndroid* web_contents_android =

reinterpret_cast<WebContentsAndroid*>(web_contents_ptr);