content/browser/renderer_host/ime_adapter_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/ime_adapter_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/android/media_drm_credential_manager.cc ('k') | content/browser/web_contents/web_contents_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/ime_adapter_android.cc

diff --git a/content/browser/renderer_host/ime_adapter_android.cc b/content/browser/renderer_host/ime_adapter_android.cc

index 88b1e126bfdefb043d1a73c0e26e499bbb9b49f0..f9519c07c680838e4cc4c4b4dbfa097f334cc13f 100644

--- a/content/browser/renderer_host/ime_adapter_android.cc

+++ b/content/browser/renderer_host/ime_adapter_android.cc

@@ -72,7 +72,7 @@ bool RegisterImeAdapter(JNIEnv* env) {

// Callback from Java to convert BackgroundColorSpan data to a

// blink::WebCompositionUnderline instance, and append it to |underlines_ptr|.

void AppendBackgroundColorSpan(JNIEnv*,

- jclass,

+ const JavaParamRef<jclass>&,

jlong underlines_ptr,

jint start,

jint end,

@@ -94,7 +94,7 @@ void AppendBackgroundColorSpan(JNIEnv*,

// Callback from Java to convert UnderlineSpan data to a

// blink::WebCompositionUnderline instance, and append it to |underlines_ptr|.

void AppendUnderlineSpan(JNIEnv*,

- jclass,

+ const JavaParamRef<jclass>&,

jlong underlines_ptr,

jint start,

jint end) {