content/browser/gamepad/gamepad_platform_data_fetcher_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/gamepad/gamepad_platform_data_fetcher_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/web_contents_observer_proxy.cc ('k') | content/browser/geolocation/location_api_adapter_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/gamepad/gamepad_platform_data_fetcher_android.cc

diff --git a/content/browser/gamepad/gamepad_platform_data_fetcher_android.cc b/content/browser/gamepad/gamepad_platform_data_fetcher_android.cc

index 46df9e53857bc46c80cb22fbb1cb4612732b12d8..471a041efe9ff6a338b5fd4a2bbdaa017e36ce97 100644

--- a/content/browser/gamepad/gamepad_platform_data_fetcher_android.cc

+++ b/content/browser/gamepad/gamepad_platform_data_fetcher_android.cc

@@ -63,15 +63,15 @@ void GamepadPlatformDataFetcherAndroid::PauseHint(bool paused) {

}

static void SetGamepadData(JNIEnv* env,

- jobject obj,

+ const JavaParamRef<jobject>& obj,

jlong gamepads,

jint index,

jboolean mapping,

jboolean connected,

- jstring devicename,

+ const JavaParamRef<jstring>& devicename,

jlong timestamp,

- jfloatArray jaxes,

- jfloatArray jbuttons) {

+ const JavaParamRef<jfloatArray>& jaxes,

+ const JavaParamRef<jfloatArray>& jbuttons) {

DCHECK(gamepads);

blink::WebGamepads* pads = reinterpret_cast<WebGamepads*>(gamepads);

DCHECK_EQ(pads->length, unsigned(index));