components/cronet/android/cronet_url_request_adapter.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/cronet_url_request_adapter.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_upload_data_stream_adapter.cc ('k') | components/cronet/android/cronet_url_request_context_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/cronet_url_request_adapter.cc

diff --git a/components/cronet/android/cronet_url_request_adapter.cc b/components/cronet/android/cronet_url_request_adapter.cc

index f3f174955381e4c769e6bc6528d13e6fc61f3565..14115e07d9d720799a2e1b438b6ca15f0b4b0e09 100644

--- a/components/cronet/android/cronet_url_request_adapter.cc

+++ b/components/cronet/android/cronet_url_request_adapter.cc

@@ -33,9 +33,9 @@ bool CronetUrlRequestAdapterRegisterJni(JNIEnv* env) {

}

static jlong CreateRequestAdapter(JNIEnv* env,

- jobject jurl_request,

+ const JavaParamRef<jobject>& jurl_request,

jlong jurl_request_context_adapter,

- jstring jurl_string,

+ const JavaParamRef<jstring>& jurl_string,

jint jpriority) {

CronetURLRequestContextAdapter* context_adapter =

reinterpret_cast<CronetURLRequestContextAdapter*>(