Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: components/cronet/android/cronet_upload_data_stream_adapter.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_upload_data_stream_adapter.cc
diff --git a/components/cronet/android/cronet_upload_data_stream_adapter.cc b/components/cronet/android/cronet_upload_data_stream_adapter.cc
index 35bc6ce1eb0725c66fe56a026e0de89a7bf2fc0e..70f98d331c958e4ab120352de5a26edd760480b0 100644
--- a/components/cronet/android/cronet_upload_data_stream_adapter.cc
+++ b/components/cronet/android/cronet_upload_data_stream_adapter.cc
@@ -99,10 +99,11 @@ bool CronetUploadDataStreamAdapterRegisterJni(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-static jlong AttachUploadDataToRequest(JNIEnv* env,
- jobject jupload_data_stream,
- jlong jcronet_url_request_adapter,
- jlong jlength) {
+static jlong AttachUploadDataToRequest(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& jupload_data_stream,
+ jlong jcronet_url_request_adapter,
+ jlong jlength) {
CronetURLRequestAdapter* request_adapter =
reinterpret_cast<CronetURLRequestAdapter*>(jcronet_url_request_adapter);
DCHECK(request_adapter != nullptr);
@@ -118,17 +119,19 @@ static jlong AttachUploadDataToRequest(JNIEnv* env,
return reinterpret_cast<jlong>(adapter);
}
-static jlong CreateAdapterForTesting(JNIEnv* env,
- jobject jupload_data_stream) {
+static jlong CreateAdapterForTesting(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& jupload_data_stream) {
CronetUploadDataStreamAdapter* adapter =
new CronetUploadDataStreamAdapter(env, jupload_data_stream);
return reinterpret_cast<jlong>(adapter);
}
-static jlong CreateUploadDataStreamForTesting(JNIEnv* env,
- jobject jupload_data_stream,
- jlong jlength,
- jlong jadapter) {
+static jlong CreateUploadDataStreamForTesting(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& jupload_data_stream,
+ jlong jlength,
+ jlong jadapter) {
CronetUploadDataStreamAdapter* adapter =
reinterpret_cast<CronetUploadDataStreamAdapter*>(jadapter);
CronetUploadDataStream* upload_data_stream =
@@ -136,9 +139,10 @@ static jlong CreateUploadDataStreamForTesting(JNIEnv* env,
return reinterpret_cast<jlong>(upload_data_stream);
}
-static void DestroyAdapter(JNIEnv* env,
- jclass jcronet_url_request_adapter,
- jlong jupload_data_stream_adapter) {
+static void DestroyAdapter(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& jcronet_url_request_adapter,
+ jlong jupload_data_stream_adapter) {
CronetUploadDataStreamAdapter* adapter =
reinterpret_cast<CronetUploadDataStreamAdapter*>(
jupload_data_stream_adapter);
« no previous file with comments | « components/cronet/android/cronet_library_loader.cc ('k') | components/cronet/android/cronet_url_request_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698