Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: components/cronet/android/cronet_library_loader.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_library_loader.cc
diff --git a/components/cronet/android/cronet_library_loader.cc b/components/cronet/android/cronet_library_loader.cc
index 8e38125344a4bab324b404b7f01453385a001f8a..aff1ffc4cf7c76260934b74e7dd6510fd504f57b 100644
--- a/components/cronet/android/cronet_library_loader.cc
+++ b/components/cronet/android/cronet_library_loader.cc
@@ -87,15 +87,15 @@ void CronetOnUnLoad(JavaVM* jvm, void* reserved) {
}
void CronetInitApplicationContext(JNIEnv* env,
- jclass jcaller,
- jobject japp_context) {
+ const JavaParamRef<jclass>& jcaller,
+ const JavaParamRef<jobject>& japp_context) {
// Set application context.
base::android::ScopedJavaLocalRef<jobject> scoped_app_context(env,
japp_context);
base::android::InitApplicationContext(env, scoped_app_context);
}
-void CronetInitOnMainThread(JNIEnv* env, jclass jcaller) {
+void CronetInitOnMainThread(JNIEnv* env, const JavaParamRef<jclass>& jcaller) {
#if !defined(USE_ICU_ALTERNATIVES_ON_ANDROID)
base::i18n::InitializeICU();
#endif
@@ -113,7 +113,9 @@ void CronetInitOnMainThread(JNIEnv* env, jclass jcaller) {
g_network_change_notifier = net::NetworkChangeNotifier::Create();
}
-ScopedJavaLocalRef<jstring> GetCronetVersion(JNIEnv* env, jclass jcaller) {
+ScopedJavaLocalRef<jstring> GetCronetVersion(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& jcaller) {
return base::android::ConvertUTF8ToJavaString(env, CRONET_VERSION);
}
« no previous file with comments | « components/cronet/android/cronet_histogram_manager.cc ('k') | components/cronet/android/cronet_upload_data_stream_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698