chrome/browser/android/precache/precache_launcher.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/precache/precache_launcher.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/password_ui_view_android.cc ('k') | chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/precache/precache_launcher.cc

diff --git a/chrome/browser/android/precache/precache_launcher.cc b/chrome/browser/android/precache/precache_launcher.cc

index db11b8cb3f2d94a96434a5ba3df4d4356e8ce359..eac5a85aff6b0bbcb5af4c720f3854276562313f 100644

--- a/chrome/browser/android/precache/precache_launcher.cc

+++ b/chrome/browser/android/precache/precache_launcher.cc

@@ -80,12 +80,12 @@ void PrecacheLauncher::OnPrecacheCompleted(bool try_again_soon) {

try_again_soon ? JNI_TRUE : JNI_FALSE);

}

-static jlong Init(JNIEnv* env, jobject obj) {

+static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {

return reinterpret_cast<intptr_t>(new PrecacheLauncher(env, obj));

}

// Must be run on the UI thread.

-static jboolean ShouldRun(JNIEnv* env, jobject obj) {

+static jboolean ShouldRun(JNIEnv* env, const JavaParamRef<jobject>& obj) {

Profile* profile = GetProfile();

PrecacheManager* precache_manager = GetPrecacheManager(profile);

return precache_manager && (precache_manager->IsInExperimentGroup() ||