Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/browser/android/password_ui_view_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/password_ui_view_android.cc
diff --git a/chrome/browser/android/password_ui_view_android.cc b/chrome/browser/android/password_ui_view_android.cc
index d71d1ed2e4d6b191f6bf9fb0b56a29f47f7f55ed..f851e94db99c69054b0bedee26ea7992af76d68c 100644
--- a/chrome/browser/android/password_ui_view_android.cc
+++ b/chrome/browser/android/password_ui_view_android.cc
@@ -110,18 +110,20 @@ void PasswordUIViewAndroid::HandleRemoveSavedPasswordException(
password_manager_presenter_.RemovePasswordException(index);
}
-ScopedJavaLocalRef<jstring> GetAccountDashboardURL(JNIEnv* env, jclass) {
+ScopedJavaLocalRef<jstring> GetAccountDashboardURL(
+ JNIEnv* env,
+ const JavaParamRef<jclass>&) {
return ConvertUTF8ToJavaString(env,
chrome::kPasswordManagerAccountDashboardURL);
}
-static jboolean ShouldDisplayManageAccountLink(
- JNIEnv* env, jclass) {
+static jboolean ShouldDisplayManageAccountLink(JNIEnv* env,
+ const JavaParamRef<jclass>&) {
return password_manager::ManageAccountLinkExperimentEnabled();
}
-static jboolean ShouldUseSmartLockBranding(
- JNIEnv* env, jclass) {
+static jboolean ShouldUseSmartLockBranding(JNIEnv* env,
+ const JavaParamRef<jclass>&) {
const ProfileSyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(
ProfileManager::GetLastUsedProfile());
@@ -129,7 +131,7 @@ static jboolean ShouldUseSmartLockBranding(
}
// static
-static jlong Init(JNIEnv* env, jobject obj) {
+static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
PasswordUIViewAndroid* controller = new PasswordUIViewAndroid(env, obj);
return reinterpret_cast<intptr_t>(controller);
}
« no previous file with comments | « chrome/browser/android/omnibox/omnibox_prerender.cc ('k') | chrome/browser/android/precache/precache_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698