Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/android/omnibox/answers_image_bridge.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/omnibox/answers_image_bridge.cc
diff --git a/chrome/browser/android/omnibox/answers_image_bridge.cc b/chrome/browser/android/omnibox/answers_image_bridge.cc
index 41d215d431167b83005f89908fdcda2200005b3e..910f48d4a98827676b50022378216fa40567b6ca 100644
--- a/chrome/browser/android/omnibox/answers_image_bridge.cc
+++ b/chrome/browser/android/omnibox/answers_image_bridge.cc
@@ -52,8 +52,8 @@ class AnswersImageObserverAndroid : public BitmapFetcherService::Observer {
} // namespace
static void CancelAnswersImageRequest(JNIEnv* env,
- jclass,
- jobject java_profile,
+ const JavaParamRef<jclass>&,
+ const JavaParamRef<jobject>& java_profile,
jint java_request_id) {
Profile* profile = ProfileAndroid::FromProfileAndroid(java_profile);
DCHECK(profile);
@@ -63,10 +63,10 @@ static void CancelAnswersImageRequest(JNIEnv* env,
}
static int RequestAnswersImage(JNIEnv* env,
- jclass,
- jobject java_profile,
- jstring java_url,
- jobject java_callback) {
+ const JavaParamRef<jclass>&,
+ const JavaParamRef<jobject>& java_profile,
+ const JavaParamRef<jstring>& java_url,
+ const JavaParamRef<jobject>& java_callback) {
Profile* profile = ProfileAndroid::FromProfileAndroid(java_profile);
DCHECK(profile);
BitmapFetcherService* bitmap_fetcher_service =

Powered by Google App Engine
This is Rietveld 408576698