Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/android/omnibox/autocomplete_controller_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/omnibox/autocomplete_controller_android.cc
diff --git a/chrome/browser/android/omnibox/autocomplete_controller_android.cc b/chrome/browser/android/omnibox/autocomplete_controller_android.cc
index 9080238a39dc106fbd6e07641fd24e899f93a2a4..221d172115512b24f60a5eafa00b6fe46455287d 100644
--- a/chrome/browser/android/omnibox/autocomplete_controller_android.cc
+++ b/chrome/browser/android/omnibox/autocomplete_controller_android.cc
@@ -508,7 +508,9 @@ AutocompleteControllerAndroid::GetTopSynchronousResult(
return BuildOmniboxSuggestion(env, *result.begin());
}
-static jlong Init(JNIEnv* env, jobject obj, jobject jprofile) {
+static jlong Init(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& jprofile) {
Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
if (!profile)
return 0;
@@ -518,9 +520,10 @@ static jlong Init(JNIEnv* env, jobject obj, jobject jprofile) {
return reinterpret_cast<intptr_t>(native_bridge);
}
-static ScopedJavaLocalRef<jstring> QualifyPartialURLQuery(JNIEnv* env,
- jclass clazz,
- jstring jquery) {
+static ScopedJavaLocalRef<jstring> QualifyPartialURLQuery(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jstring>& jquery) {
Profile* profile = ProfileManager::GetActiveUserProfile();
if (!profile)
return ScopedJavaLocalRef<jstring>();
@@ -546,7 +549,8 @@ static ScopedJavaLocalRef<jstring> QualifyPartialURLQuery(JNIEnv* env,
return ConvertUTF8ToJavaString(env, match.destination_url.spec());
}
-static void PrefetchZeroSuggestResults(JNIEnv* env, jclass clazz) {
+static void PrefetchZeroSuggestResults(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz) {
Profile* profile = ProfileManager::GetActiveUserProfile();
if (!profile)
return;
« no previous file with comments | « chrome/browser/android/omnibox/answers_image_bridge.cc ('k') | chrome/browser/android/omnibox/omnibox_prerender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698