Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4074)

Unified Diff: chrome/browser/android/dev_tools_server.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/dev_tools_server.cc
diff --git a/chrome/browser/android/dev_tools_server.cc b/chrome/browser/android/dev_tools_server.cc
index 20aea051378648fc2d6f4d0d89d10cce5f7691a0..13faafea2bc7f32e7003b4a670af7c405c60fd9e 100644
--- a/chrome/browser/android/dev_tools_server.cc
+++ b/chrome/browser/android/dev_tools_server.cc
@@ -229,26 +229,29 @@ bool RegisterDevToolsServer(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-static jlong InitRemoteDebugging(JNIEnv* env,
- jobject obj,
- jstring socket_name_prefix) {
+static jlong InitRemoteDebugging(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& socket_name_prefix) {
DevToolsServer* server = new DevToolsServer(
base::android::ConvertJavaStringToUTF8(env, socket_name_prefix));
return reinterpret_cast<intptr_t>(server);
}
-static void DestroyRemoteDebugging(JNIEnv* env, jobject obj, jlong server) {
+static void DestroyRemoteDebugging(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jlong server) {
delete reinterpret_cast<DevToolsServer*>(server);
}
static jboolean IsRemoteDebuggingEnabled(JNIEnv* env,
- jobject obj,
+ const JavaParamRef<jobject>& obj,
jlong server) {
return reinterpret_cast<DevToolsServer*>(server)->IsStarted();
}
static void SetRemoteDebuggingEnabled(JNIEnv* env,
- jobject obj,
+ const JavaParamRef<jobject>& obj,
jlong server,
jboolean enabled,
jboolean allow_debug_permission) {
« no previous file with comments | « chrome/browser/android/cookies/cookies_fetcher.cc ('k') | chrome/browser/android/document/document_web_contents_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698