Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: chrome/browser/android/dev_tools_server.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/dev_tools_server.h" 5 #include "chrome/browser/android/dev_tools_server.h"
6 6
7 #include <pwd.h> 7 #include <pwd.h>
8 #include <cstring> 8 #include <cstring>
9 9
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 } 222 }
223 223
224 bool DevToolsServer::IsStarted() const { 224 bool DevToolsServer::IsStarted() const {
225 return devtools_http_handler_; 225 return devtools_http_handler_;
226 } 226 }
227 227
228 bool RegisterDevToolsServer(JNIEnv* env) { 228 bool RegisterDevToolsServer(JNIEnv* env) {
229 return RegisterNativesImpl(env); 229 return RegisterNativesImpl(env);
230 } 230 }
231 231
232 static jlong InitRemoteDebugging(JNIEnv* env, 232 static jlong InitRemoteDebugging(
233 jobject obj, 233 JNIEnv* env,
234 jstring socket_name_prefix) { 234 const JavaParamRef<jobject>& obj,
235 const JavaParamRef<jstring>& socket_name_prefix) {
235 DevToolsServer* server = new DevToolsServer( 236 DevToolsServer* server = new DevToolsServer(
236 base::android::ConvertJavaStringToUTF8(env, socket_name_prefix)); 237 base::android::ConvertJavaStringToUTF8(env, socket_name_prefix));
237 return reinterpret_cast<intptr_t>(server); 238 return reinterpret_cast<intptr_t>(server);
238 } 239 }
239 240
240 static void DestroyRemoteDebugging(JNIEnv* env, jobject obj, jlong server) { 241 static void DestroyRemoteDebugging(JNIEnv* env,
242 const JavaParamRef<jobject>& obj,
243 jlong server) {
241 delete reinterpret_cast<DevToolsServer*>(server); 244 delete reinterpret_cast<DevToolsServer*>(server);
242 } 245 }
243 246
244 static jboolean IsRemoteDebuggingEnabled(JNIEnv* env, 247 static jboolean IsRemoteDebuggingEnabled(JNIEnv* env,
245 jobject obj, 248 const JavaParamRef<jobject>& obj,
246 jlong server) { 249 jlong server) {
247 return reinterpret_cast<DevToolsServer*>(server)->IsStarted(); 250 return reinterpret_cast<DevToolsServer*>(server)->IsStarted();
248 } 251 }
249 252
250 static void SetRemoteDebuggingEnabled(JNIEnv* env, 253 static void SetRemoteDebuggingEnabled(JNIEnv* env,
251 jobject obj, 254 const JavaParamRef<jobject>& obj,
252 jlong server, 255 jlong server,
253 jboolean enabled, 256 jboolean enabled,
254 jboolean allow_debug_permission) { 257 jboolean allow_debug_permission) {
255 DevToolsServer* devtools_server = reinterpret_cast<DevToolsServer*>(server); 258 DevToolsServer* devtools_server = reinterpret_cast<DevToolsServer*>(server);
256 if (enabled) { 259 if (enabled) {
257 devtools_server->Start(allow_debug_permission); 260 devtools_server->Start(allow_debug_permission);
258 } else { 261 } else {
259 devtools_server->Stop(); 262 devtools_server->Stop();
260 } 263 }
261 } 264 }
OLDNEW
« no previous file with comments | « chrome/browser/android/cookies/cookies_fetcher.cc ('k') | chrome/browser/android/document/document_web_contents_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698