Issue 13121002: Make GrGLShaderBuilder::TextureSampler extract only required info from GrTextureAccess.

Issue 13121002: Make GrGLShaderBuilder::TextureSampler extract only required info from GrTextureAccess. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make GrGLShaderBuilder::TextureSampler extract only required info from GrTextureAccess. This will make it possible to init a TextureSampler without a texture or a specific config. Also unify two separate bitfields of color components in GPU code. Committed: https://code.google.com/p/skia/source/detail?r=8428

Patch Set 1 #

Total comments: 4

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -91 lines)			Patch
M	include/gpu/GrColor.h	View	1 chunk	+40 lines, -0 lines	0 comments	Download
M	include/gpu/GrEffect.h	View	1 chunk	+4 lines, -17 lines	0 comments	Download
M	include/gpu/GrTextureAccess.h	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	include/gpu/GrTypes.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/effects/SkBlendImageFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/effects/gradients/SkGradientShader.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrTextureAccess.cpp	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	src/gpu/effects/GrSingleTextureEffect.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View	3 chunks	+32 lines, -13 lines	2 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.cpp	View	4 chunks	+7 lines, -18 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 v. minor nit + 1 question https://codereview.chromium.org/13121002/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp File src/gpu/gl/GrGLShaderBuilder.cpp (right): https://codereview.chromium.org/13121002/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp#newcode61 src/gpu/gl/GrGLShaderBuilder.cpp:61: ...

7 years, 9 months ago (2013-03-28 13:38:29 UTC) #2

bsalomon

https://codereview.chromium.org/13121002/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp File src/gpu/gl/GrGLShaderBuilder.cpp (right): https://codereview.chromium.org/13121002/diff/1/src/gpu/gl/GrGLShaderBuilder.cpp#newcode61 src/gpu/gl/GrGLShaderBuilder.cpp:61: if (!caps.textureSwizzleSupport() && On 2013/03/28 13:38:29, robertphillips wrote: > ...

7 years, 9 months ago (2013-03-28 13:46:00 UTC) #3

bsalomon

7 years, 9 months ago (2013-03-28 13:47:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r8428 (presubmit successful).

Expand Messages | Collapse Messages