Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: include/gpu/GrEffect.h

Issue 13121002: Make GrGLShaderBuilder::TextureSampler extract only required info from GrTextureAccess. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: include/gpu/GrEffect.h
===================================================================
--- include/gpu/GrEffect.h (revision 8417)
+++ include/gpu/GrEffect.h (working copy)
@@ -87,24 +87,11 @@
virtual ~GrEffect();
/**
- * Flags for getConstantColorComponents. They are defined so that the bit order reflects the
- * GrColor shift order.
- */
- enum ValidComponentFlags {
- kR_ValidComponentFlag = 1 << (GrColor_SHIFT_R / 8),
- kG_ValidComponentFlag = 1 << (GrColor_SHIFT_G / 8),
- kB_ValidComponentFlag = 1 << (GrColor_SHIFT_B / 8),
- kA_ValidComponentFlag = 1 << (GrColor_SHIFT_A / 8),
-
- kAll_ValidComponentFlags = (kR_ValidComponentFlag | kG_ValidComponentFlag |
- kB_ValidComponentFlag | kA_ValidComponentFlag)
- };
-
- /**
* This function is used to perform optimizations. When called the color and validFlags params
- * indicate whether the input components to this effect in the FS will have known values. The
- * function updates both params to indicate known values of its output. A component of the color
- * param only has meaning if the corresponding bit in validFlags is set.
+ * indicate whether the input components to this effect in the FS will have known values.
+ * validFlags is a bitfield of GrColorComponentFlags. The function updates both params to
+ * indicate known values of its output. A component of the color param only has meaning if the
+ * corresponding bit in validFlags is set.
*/
virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const = 0;

Powered by Google App Engine
This is Rietveld 408576698