Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3993)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java

Issue 1311913007: Do not select a Tab while closing all tabs or undoing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java
index 4b33b9bf1bec2616f1ff936d2b404908703f2e43..3336974c0d15e86c6ca1b9ea5325d06a67aeb7cc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java
@@ -161,17 +161,19 @@ public class UndoBarPopupController implements SnackbarManager.SnackbarControlle
RecordHistogram.recordEnumeratedHistogram("AndroidTabCloseUndo.Toast",
TAB_CLOSE_UNDO_TOAST_PRESSED, TAB_CLOSE_UNDO_TOAST_COUNT);
if (actionData instanceof Integer) {
- cancelTabClosure((Integer) actionData);
+ cancelTabClosure((Integer) actionData, false);
Ted C 2015/09/02 20:30:56 somewhat like my other comment, what if we change
Jaekyun Seok (inactive) 2015/09/03 00:27:58 Done.
} else {
- for (Integer id : (List<Integer>) actionData) {
- cancelTabClosure(id);
+ List<Integer> idList = (List<Integer>) actionData;
+ for (int i = 0; i < idList.size(); i++) {
+ Integer id = idList.get(i);
+ cancelTabClosure(id, i != idList.size() - 1);
}
}
}
- private void cancelTabClosure(int tabId) {
+ private void cancelTabClosure(int tabId, boolean isHidden) {
TabModel model = mTabModelSelector.getModelForTabId(tabId);
- if (model != null) model.cancelTabClosure(tabId);
+ if (model != null) model.cancelTabClosure(tabId, isHidden);
}
/**

Powered by Google App Engine
This is Rietveld 408576698