chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java - Issue 1311913007: Do not select a Tab while closing all tabs or undoing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 1311913007: Do not select a Tab while closing all tabs or undoing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/snackbar/undo/UndoBarPopupController.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/EmptyTabModel.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

index 678e74bc7fd0aadbb75e66d7a8c727e6052791c8..5ac64473e1bb425ad98779fcaa9117586d29d286 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

@@ -254,7 +254,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {

ChromeTab newTab = createNewTab(

loadUrlParams, TabLaunchType.FROM_EXTERNAL_APP, null, i, intent);

newTab.setAppAssociatedWith(appId);

- mTabModel.closeTab(tab, false, false, false);

+ mTabModel.closeTab(tab, false, false, false, false);

return newTab;

}