Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311853004: Rename visiblePositionOf() to createVisiblePosition() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename visiblePositionOf() to createVisiblePosition() This patch renames |visiblePositionOf()| to |createVisiblePosition()| to follow a review comment in http://crrev.com/1326563002, to indicate this function isn't cheap like a accessor for improving code health. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201535

Patch Set 1 : 2015-09-01T14:43:58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -51 lines) Patch
M Source/core/editing/DragCaretController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/SelectionController.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/editing/VisiblePositionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/serializers/StyledMarkupSerializer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/HitTestResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/PendingSelection.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSurroundingText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-01 06:18:42 UTC) #2
tkent
lgtm
5 years, 3 months ago (2015-09-01 06:30:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311853004/1
5 years, 3 months ago (2015-09-01 06:36:59 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 08:24:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201535

Powered by Google App Engine
This is Rietveld 408576698