Source/core/editing/VisiblePositionTest.cpp - Issue 1311853004: Rename visiblePositionOf() to createVisiblePosition()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/editing/VisiblePositionTest.cpp

Issue 1311853004: Rename visiblePositionOf() to createVisiblePosition() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-01T14:43:58 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/editing/VisiblePosition.cpp ('k') | Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "config.h"	5 #include "config.h"

6 #include "core/editing/VisiblePosition.h"	6 #include "core/editing/VisiblePosition.h"

7	7

8 #include "core/editing/EditingTestBase.h"	8 #include "core/editing/EditingTestBase.h"

9	9

10 namespace blink {	10 namespace blink {

(...skipping 13 matching lines...) Expand all Loading...
24 RefPtrWillBeRawPtr<Element> two = body->querySelector("#two", ASSERT_NO_EXCE PTION);	24 RefPtrWillBeRawPtr<Element> two = body->querySelector("#two", ASSERT_NO_EXCE PTION);

25 RefPtrWillBeRawPtr<Element> four = shadowRoot->querySelector("#s4", ASSERT_N O_EXCEPTION);	25 RefPtrWillBeRawPtr<Element> four = shadowRoot->querySelector("#s4", ASSERT_N O_EXCEPTION);

26 RefPtrWillBeRawPtr<Element> five = shadowRoot->querySelector("#s5", ASSERT_N O_EXCEPTION);	26 RefPtrWillBeRawPtr<Element> five = shadowRoot->querySelector("#s5", ASSERT_N O_EXCEPTION);

27	27

28 EXPECT_EQ(Position(one->firstChild(), 0), canonicalPositionOf(Position(one, 0)));	28 EXPECT_EQ(Position(one->firstChild(), 0), canonicalPositionOf(Position(one, 0)));

29 EXPECT_EQ(Position(one->firstChild(), 0), VisiblePosition(Position(one, 0)). deepEquivalent());	29 EXPECT_EQ(Position(one->firstChild(), 0), VisiblePosition(Position(one, 0)). deepEquivalent());

30 EXPECT_EQ(Position(one->firstChild(), 2), canonicalPositionOf(Position(two.g et(), 0)));	30 EXPECT_EQ(Position(one->firstChild(), 2), canonicalPositionOf(Position(two.g et(), 0)));

31 EXPECT_EQ(Position(one->firstChild(), 2), VisiblePosition(Position(two.get() , 0)).deepEquivalent());	31 EXPECT_EQ(Position(one->firstChild(), 2), VisiblePosition(Position(two.get() , 0)).deepEquivalent());

32	32

33 EXPECT_EQ(PositionInComposedTree(five->firstChild(), 2), canonicalPositionOf (PositionInComposedTree(one.get(), 0)));	33 EXPECT_EQ(PositionInComposedTree(five->firstChild(), 2), canonicalPositionOf (PositionInComposedTree(one.get(), 0)));

34 EXPECT_EQ(Position(five->firstChild(), 2), visiblePositionOf(PositionInCompo sedTree(one.get(), 0)).deepEquivalent());	34 EXPECT_EQ(Position(five->firstChild(), 2), createVisiblePosition(PositionInC omposedTree(one.get(), 0)).deepEquivalent());

35 EXPECT_EQ(PositionInComposedTree(four->firstChild(), 2), canonicalPositionOf (PositionInComposedTree(two.get(), 0)));	35 EXPECT_EQ(PositionInComposedTree(four->firstChild(), 2), canonicalPositionOf (PositionInComposedTree(two.get(), 0)));

36 EXPECT_EQ(Position(four->firstChild(), 2), visiblePositionOf(PositionInCompo sedTree(two.get(), 0)).deepEquivalent());	36 EXPECT_EQ(Position(four->firstChild(), 2), createVisiblePosition(PositionInC omposedTree(two.get(), 0)).deepEquivalent());

37 }	37 }

38	38

39 } // namespace blink	39 } // namespace blink

OLD	NEW