Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311843003: Remove default case from CSSValue::equals (Closed)

Created:
5 years, 4 months ago by sashab
Modified:
5 years, 4 months ago
Reviewers:
Timothy Loh, esprehn
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears, esprehn, shans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove default case from CSSValue::equals Remove the default case from the CSSValue::equals method, to enable the compiler to check that every enum value is in the switch statement. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/css/CSSValue.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
sashab
5 years, 4 months ago (2015-08-25 05:54:32 UTC) #2
Timothy Loh
On 2015/08/25 05:54:32, sashab wrote: lgtm, but I don't see how this relates to the ...
5 years, 4 months ago (2015-08-25 05:57:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311843003/1
5 years, 4 months ago (2015-08-25 05:59:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103634)
5 years, 4 months ago (2015-08-25 06:50:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311843003/1
5 years, 4 months ago (2015-08-25 06:55:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103661)
5 years, 4 months ago (2015-08-25 07:48:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311843003/1
5 years, 4 months ago (2015-08-25 07:51:30 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 09:10:49 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201114

Powered by Google App Engine
This is Rietveld 408576698