Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: Source/core/css/CSSValue.cpp

Issue 1311843003: Remove default case from CSSValue::equals (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSValue.cpp
diff --git a/Source/core/css/CSSValue.cpp b/Source/core/css/CSSValue.cpp
index cae937c0faa8c7177c5b8d4b6ed4faadcb6cc67f..4f9805848f9867caff5fa16af3943f92b8d4b4b2 100644
--- a/Source/core/css/CSSValue.cpp
+++ b/Source/core/css/CSSValue.cpp
@@ -92,7 +92,7 @@ inline static bool compareCSSValues(const CSSValue& first, const CSSValue& secon
bool CSSValue::equals(const CSSValue& other) const
{
if (m_classType == other.m_classType) {
- switch (m_classType) {
+ switch (classType()) {
case BorderImageSliceClass:
return compareCSSValues<CSSBorderImageSliceValue>(*this, other);
case CanvasClass:
@@ -149,10 +149,9 @@ bool CSSValue::equals(const CSSValue& other) const
return compareCSSValues<CSSSVGDocumentValue>(*this, other);
case CSSContentDistributionClass:
return compareCSSValues<CSSContentDistributionValue>(*this, other);
- default:
- ASSERT_NOT_REACHED();
- return false;
}
+ ASSERT_NOT_REACHED();
+ return false;
}
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698