Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311793002: Modify GrBWFillRectBatch to use GrQuad (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 1

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -123 lines) Patch
M src/gpu/GrQuad.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/gpu/batches/GrBWFillRectBatch.cpp View 1 2 7 chunks +76 lines, -123 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
joshualitt
ptal
5 years, 3 months ago (2015-08-24 14:38:32 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/1311793002/diff/20001/src/gpu/batches/GrBWFillRectBatch.cpp File src/gpu/batches/GrBWFillRectBatch.cpp (right): https://codereview.chromium.org/1311793002/diff/20001/src/gpu/batches/GrBWFillRectBatch.cpp#newcode55 src/gpu/batches/GrBWFillRectBatch.cpp:55: // If we have perspective on the viewMatrix ...
5 years, 3 months ago (2015-08-24 15:24:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311793002/40001
5 years, 3 months ago (2015-08-24 15:37:51 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/c611b5afbef6df6c02e949fdf092aab2bb7e0e2e
5 years, 3 months ago (2015-08-24 15:43:15 UTC) #7
joshualitt
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1313683002/ by joshualitt@google.com. ...
5 years, 3 months ago (2015-08-24 17:25:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311793002/40001
5 years, 3 months ago (2015-08-26 13:18:45 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 13:23:42 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8cce8f139e4b91783722f11ccb6ac9bbdf8327e7

Powered by Google App Engine
This is Rietveld 408576698