Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311673014: Remove GrAddPathRenderers_default (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrAddPathRenderers_default BUG=skia: Committed: https://skia.googlesource.com/skia/+/0cffb171eb2c8b94ec61fcd833df03870eece1b2

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -866 lines) Patch
M gyp/gpu.gypi View 3 chunks +2 lines, -3 lines 0 comments Download
D src/gpu/GrAddPathRenderers_default.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
D src/gpu/GrDefaultPathRenderer.h View 1 chunk +0 lines, -46 lines 0 comments Download
D src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +0 lines, -761 lines 0 comments Download
M src/gpu/GrPathRenderer.h View 1 chunk +0 lines, -14 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 1 2 chunks +23 lines, -6 lines 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.h View 2 chunks +1 line, -3 lines 0 comments Download
A + src/gpu/batches/GrDefaultPathRenderer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/gpu/batches/GrDefaultPathRenderer.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal, this CL also moves GrDefaultPathRenderer to batches
5 years, 3 months ago (2015-09-02 14:07:11 UTC) #2
robertphillips
lgtm + nit https://codereview.chromium.org/1311673014/diff/1/src/gpu/GrPathRendererChain.cpp File src/gpu/GrPathRendererChain.cpp (right): https://codereview.chromium.org/1311673014/diff/1/src/gpu/GrPathRendererChain.cpp#newcode18 src/gpu/GrPathRendererChain.cpp:18: #include "batches/GrAALinearizingConvexPathRenderer.h" GrAAD before GrAAL and ...
5 years, 3 months ago (2015-09-02 15:19:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311673014/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311673014/20001
5 years, 3 months ago (2015-09-02 15:36:50 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 15:42:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0cffb171eb2c8b94ec61fcd833df03870eece1b2

Powered by Google App Engine
This is Rietveld 408576698