Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311673011: ipc: Add a new field num_brokered_attachments to the message header. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Add a new field num_brokered_attachments to the message header. BUG=493414 Committed: https://crrev.com/9e3e945e56139cf34634dc21ad25a67fc5507590 Cr-Commit-Position: refs/heads/master@{#346426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ipc/ipc_message.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ipc/ipc_message.cc View 3 chunks +12 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1321093003 Patch 20001

Messages

Total messages: 16 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311673011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311673011/1
5 years, 3 months ago (2015-08-28 19:46:17 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/100261)
5 years, 3 months ago (2015-08-28 21:37:03 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311673011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311673011/1
5 years, 3 months ago (2015-08-28 21:41:17 UTC) #6
erikchen
tsepez: Please review. This CL was broken out of "IPC: Add attachment brokering support to ...
5 years, 3 months ago (2015-08-28 22:53:53 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 23:56:33 UTC) #10
Tom Sepez
lgtm
5 years, 3 months ago (2015-08-31 17:15:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311673011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311673011/1
5 years, 3 months ago (2015-08-31 17:22:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 18:47:09 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e3e945e56139cf34634dc21ad25a67fc5507590 Cr-Commit-Position: refs/heads/master@{#346426}
5 years, 3 months ago (2015-08-31 18:48:09 UTC) #15
erikchen
5 years, 3 months ago (2015-09-01 18:24:35 UTC) #16
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1326703002/ by erikchen@chromium.org.

The reason for reverting is: Causes crashes on Canary:
https://code.google.com/p/chromium/issues/detail?id=524032.

Powered by Google App Engine
This is Rietveld 408576698