Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1321093003: ipc: Add methods for AttachmentBroker nonce serialization. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Add methods for AttachmentBroker nonce serialization. BUG=493414 Committed: https://crrev.com/81352753aadf047281669c9c229bebe016310b4d Cr-Commit-Position: refs/heads/master@{#347312}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Comments from tsepez. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M ipc/brokerable_attachment.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M ipc/brokerable_attachment.cc View 1 chunk +27 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321093003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321093003/20001
5 years, 3 months ago (2015-08-28 20:10:52 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 21:22:15 UTC) #4
erikchen
tsepez: Please review. This CL was broken out of "IPC: Add attachment brokering support to ...
5 years, 3 months ago (2015-08-28 21:30:33 UTC) #6
Tom Sepez
lgtm https://codereview.chromium.org/1321093003/diff/20001/ipc/brokerable_attachment.h File ipc/brokerable_attachment.h (right): https://codereview.chromium.org/1321093003/diff/20001/ipc/brokerable_attachment.h#newcode25 ipc/brokerable_attachment.h:25: // Default constructor returns a random nonce. nit: ...
5 years, 3 months ago (2015-09-01 17:54:23 UTC) #7
erikchen
https://codereview.chromium.org/1321093003/diff/20001/ipc/brokerable_attachment.h File ipc/brokerable_attachment.h (right): https://codereview.chromium.org/1321093003/diff/20001/ipc/brokerable_attachment.h#newcode25 ipc/brokerable_attachment.h:25: // Default constructor returns a random nonce. On 2015/09/01 ...
5 years, 3 months ago (2015-09-04 01:13:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321093003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321093003/40001
5 years, 3 months ago (2015-09-04 01:13:57 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-04 02:37:28 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 02:38:33 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/81352753aadf047281669c9c229bebe016310b4d
Cr-Commit-Position: refs/heads/master@{#347312}

Powered by Google App Engine
This is Rietveld 408576698