Introduce composed tree version of firstEditableVisiblePositionAfterPositionInRoot()

Source/core/editing/EditingUtilitiesTest.cpp

Index: Source/core/editing/EditingUtilitiesTest.cpp
diff --git a/Source/core/editing/EditingUtilitiesTest.cpp b/Source/core/editing/EditingUtilitiesTest.cpp
index cc7f02fd136dfb0f259855d1a87d3cfbc06573a3..e7b2809953e8692e85fc3297e388be99659da04f 100644
--- a/Source/core/editing/EditingUtilitiesTest.cpp
+++ b/Source/core/editing/EditingUtilitiesTest.cpp
@@ -32,16 +32,21 @@ TEST_F(EditingUtilitiesTest, firstEditablePositionAfterPositionInRoot)
     setBodyContent(bodyContent);
     RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent, "host");
     updateLayoutAndStyleForPainting();
-    Node* host = document().getElementById("host");
+    Element* host = document().getElementById("host");
     Node* one = document().getElementById("one");
+    Node* two = document().getElementById("two");
     Node* three = shadowRoot->getElementById("three");
 
     EXPECT_EQ(Position(one, 0), firstEditablePositionAfterPositionInRoot(Position(one, 0), host));
+    EXPECT_EQ(Position(two->firstChild(), 0), firstEditableVisiblePositionAfterPositionInRoot(Position(one, 0), host).deepEquivalent());
 
     EXPECT_EQ(PositionInComposedTree(one, 0), firstEditablePositionAfterPositionInRoot(PositionInComposedTree(one, 0), host));
+    EXPECT_EQ(PositionInComposedTree(two->firstChild(), 2), firstEditableVisiblePositionAfterPositionInRoot(PositionInComposedTree(one, 0), host).deepEquivalent());

[yoichio, 2015/09/08 01:34:28]

PositionInComposedTree(one, 0) seems not in a DOM tree |host|.
Could you explain?

[yoichio, 2015/09/08 01:43:04]

Plus, why after |PositionInComposedTree(one, 0)| is (two, 2) not (three, 0)?

[yosin_UTC9, 2015/09/08 02:04:32]

Since, canonicalized position of PosICT(one, 0) is PosICT("22", 2).
PosICT(one, 0) is result of firstEditablePositionAfterPositionInRoot() as
of test in L43.

We may want to rename firstEditablePositionAfterPositionInRoot() to
firstEditablePositionAtOrAfterPositionInRoot().

 
     EXPECT_EQ(Position::firstPositionInNode(host), firstEditablePositionAfterPositionInRoot(Position(three, 0), host));
+    EXPECT_EQ(Position(two->firstChild(), 0), firstEditableVisiblePositionAfterPositionInRoot(Position(three, 0), host).deepEquivalent());
     EXPECT_EQ(PositionInComposedTree::afterNode(host), firstEditablePositionAfterPositionInRoot(PositionInComposedTree(three, 0), host));
+    EXPECT_EQ(PositionInComposedTree::lastPositionInNode(host), firstEditableVisiblePositionAfterPositionInRoot(PositionInComposedTree(three, 0), host).deepEquivalent());
 }
 
 TEST_F(EditingUtilitiesTest, enclosingBlock)