Introduce composed tree version of firstEditableVisiblePositionAfterPositionInRoot()

Source/core/editing/EditingUtilitiesTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/editing/EditingUtilities.h"
 
 #include "core/editing/EditingTestBase.h"
 
 namespace blink {
@@ skipping 14 matching lines @@
     EXPECT_EQ(RTL, directionOfEnclosingBlock(PositionInComposedTree(one, 0)));
 }
 
 TEST_F(EditingUtilitiesTest, firstEditablePositionAfterPositionInRoot)
 {
     const char* bodyContent = "<p id='host' contenteditable><b id='one'></b><b id='two'>22</b></p>";
     const char* shadowContent = "<content select=#two></content><content select=#one></content><b id='three'>333</b>";
     setBodyContent(bodyContent);
     RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent, "host");
     updateLayoutAndStyleForPainting();
-    Node* host = document().getElementById("host");
+    Element* host = document().getElementById("host");
     Node* one = document().getElementById("one");
+    Node* two = document().getElementById("two");
     Node* three = shadowRoot->getElementById("three");
 
     EXPECT_EQ(Position(one, 0), firstEditablePositionAfterPositionInRoot(Position(one, 0), host));
+    EXPECT_EQ(Position(two->firstChild(), 0), firstEditableVisiblePositionAfterPositionInRoot(Position(one, 0), host).deepEquivalent());
 
     EXPECT_EQ(PositionInComposedTree(one, 0), firstEditablePositionAfterPositionInRoot(PositionInComposedTree(one, 0), host));
+    EXPECT_EQ(PositionInComposedTree(two->firstChild(), 2), firstEditableVisiblePositionAfterPositionInRoot(PositionInComposedTree(one, 0), host).deepEquivalent());

[yoichio, 2015/09/08 01:34:28]

PositionInComposedTree(one, 0) seems not in a DOM tree |host|.
Could you explain?

[yoichio, 2015/09/08 01:43:04]

Plus, why after |PositionInComposedTree(one, 0)| is (two, 2) not (three, 0)?

[yosin_UTC9, 2015/09/08 02:04:32]

Since, canonicalized position of PosICT(one, 0) is PosICT("22", 2).
PosICT(one, 0) is result of firstEditablePositionAfterPositionInRoot() as
of test in L43.

We may want to rename firstEditablePositionAfterPositionInRoot() to
firstEditablePositionAtOrAfterPositionInRoot().

 
     EXPECT_EQ(Position::firstPositionInNode(host), firstEditablePositionAfterPositionInRoot(Position(three, 0), host));
+    EXPECT_EQ(Position(two->firstChild(), 0), firstEditableVisiblePositionAfterPositionInRoot(Position(three, 0), host).deepEquivalent());
     EXPECT_EQ(PositionInComposedTree::afterNode(host), firstEditablePositionAfterPositionInRoot(PositionInComposedTree(three, 0), host));
+    EXPECT_EQ(PositionInComposedTree::lastPositionInNode(host), firstEditableVisiblePositionAfterPositionInRoot(PositionInComposedTree(three, 0), host).deepEquivalent());
 }
 
 TEST_F(EditingUtilitiesTest, enclosingBlock)
 {
     const char* bodyContent = "<p id='host'><b id='one'>11</b></p>";
     const char* shadowContent = "<content select=#two></content><div id='three'><content select=#one></content></div>";
     setBodyContent(bodyContent);
     RefPtrWillBeRawPtr<ShadowRoot> shadowRoot = setShadowContent(shadowContent, "host");
     updateLayoutAndStyleForPainting();
     Node* host = document().getElementById("host");
@@ skipping 41 matching lines @@
     updateLayoutAndStyleForPainting();
     Node* one = document().getElementById("one");
     Node* two = document().getElementById("two");
     Node* three = document().getElementById("three");
 
     EXPECT_EQ(Position(two->firstChild(), 1), nextVisuallyDistinctCandidate(Position(one, 1)));
     EXPECT_EQ(PositionInComposedTree(three->firstChild(), 1), nextVisuallyDistinctCandidate(PositionInComposedTree(one, 1)));
 }
 
 } // namespace blink