Introduce composed tree version of firstEditableVisiblePositionAfterPositionInRoot()

Introduce composed tree version of firstEditableVisiblePositionAfterPositionInRoot()

This patch introduces composed tree version of
|firstEditableVisiblePositionAfterPositionInRoot()| for introducing composed
tree version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201896

[yosin_UTC9, 2015-09-07 09:36:28]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2015-09-07 11:36:12]

PTAL

mac_chromium_rel_ng and win_chromium_rel_ng failures aren't
related to this patch.

[yoichio, 2015-09-08 01:34:29]

https://codereview.chromium.org/1311543006/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilitiesTest.cpp (right):

https://codereview.chromium.org/1311543006/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilitiesTest.cpp:44:
EXPECT_EQ(PositionInComposedTree(two->firstChild(), 2),
firstEditableVisiblePositionAfterPositionInRoot(PositionInComposedTree(one, 0),
host).deepEquivalent());
PositionInComposedTree(one, 0) seems not in a DOM tree |host|.
Could you explain?

[yoichio, 2015-09-08 01:43:04]

https://codereview.chromium.org/1311543006/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilitiesTest.cpp (right):

https://codereview.chromium.org/1311543006/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilitiesTest.cpp:44:
EXPECT_EQ(PositionInComposedTree(two->firstChild(), 2),
firstEditableVisiblePositionAfterPositionInRoot(PositionInComposedTree(one, 0),
host).deepEquivalent());
On 2015/09/08 01:34:28, yoichio wrote:
> PositionInComposedTree(one, 0) seems not in a DOM tree |host|.
> Could you explain?

Plus, why after |PositionInComposedTree(one, 0)| is (two, 2) not (three, 0)?

[yosin_UTC9, 2015-09-08 02:04:32]

https://codereview.chromium.org/1311543006/diff/1/Source/core/editing/Editing...
File Source/core/editing/EditingUtilitiesTest.cpp (right):

https://codereview.chromium.org/1311543006/diff/1/Source/core/editing/Editing...
Source/core/editing/EditingUtilitiesTest.cpp:44:
EXPECT_EQ(PositionInComposedTree(two->firstChild(), 2),
firstEditableVisiblePositionAfterPositionInRoot(PositionInComposedTree(one, 0),
host).deepEquivalent());
On 2015/09/08 01:34:28, yoichio wrote:
> PositionInComposedTree(one, 0) seems not in a DOM tree |host|.
> Could you explain?

Since, canonicalized position of PosICT(one, 0) is PosICT("22", 2).
PosICT(one, 0) is result of firstEditablePositionAfterPositionInRoot() as
of test in L43.

We may want to rename firstEditablePositionAfterPositionInRoot() to
firstEditablePositionAtOrAfterPositionInRoot().

[yosin_UTC9, 2015-09-08 02:16:25]

PTAL

Previous test case contains confusing position,
<b id=one></b>; no children in element.

PS#2 changes this to contain text node to make
test case easier to understand.

[yoichio, 2015-09-08 03:25:49]

lgtm

We discussed offline and found |firstEditableVisiblePositionAfterPositionInRoot|
 does not always return 'after' position because of canonicalization.
However this is a kind of refactoring thus,
lgtm with comment to .h describing this.

[yosin_UTC9, 2015-09-08 04:01:30]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-09-08 04:01:30]

The patchset sent to the CQ was uploaded after l-g-t-m from yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/1311543006/#ps40001
(title: "2015-09-08T13:00:05 Add TODO for
firstEditableVisiblePositionAfterPositionInRoot()")

[commit-bot: I haz the power, 2015-09-08 04:01:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311543006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311543006/40001

[commit-bot: I haz the power, 2015-09-08 04:54:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 04:54:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yosin_UTC9, 2015-09-08 05:21:05]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-09-08 05:21:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311543006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311543006/40001

[commit-bot: I haz the power, 2015-09-08 05:57:40]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201896