Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1311493002: [Chromecast] ATV: don't include logs from renderer process in logfile. (Closed)

Created:
5 years, 4 months ago by gunsch
Modified:
5 years, 4 months ago
Reviewers:
slan, halliwell
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] ATV: don't include logs from renderer process in logfile. Higher level of restrictions in M turn these into SELinux denials. R=halliwell@chromium.org,slan@chromium.org BUG=internal b/22888548 Committed: https://crrev.com/3f39ec09100c898b5357b7a6230542229c8f5deb Cr-Commit-Position: refs/heads/master@{#344848}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M chromecast/app/cast_main_delegate.cc View 1 chunk +9 lines, -10 lines 1 comment Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 4 months ago (2015-08-21 19:36:16 UTC) #1
halliwell
On 2015/08/21 19:36:16, gunsch wrote: lgtm
5 years, 4 months ago (2015-08-21 20:10:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311493002/1
5 years, 4 months ago (2015-08-21 20:11:45 UTC) #4
slan
lgtm https://codereview.chromium.org/1311493002/diff/1/chromecast/app/cast_main_delegate.cc File chromecast/app/cast_main_delegate.cc (right): https://codereview.chromium.org/1311493002/diff/1/chromecast/app/cast_main_delegate.cc#newcode70 chromecast/app/cast_main_delegate.cc:70: if (process_type.empty()) { Could we add a note ...
5 years, 4 months ago (2015-08-21 20:12:14 UTC) #5
gunsch
On 2015/08/21 20:12:14, slan wrote: > lgtm > > https://codereview.chromium.org/1311493002/diff/1/chromecast/app/cast_main_delegate.cc > File chromecast/app/cast_main_delegate.cc (right): > ...
5 years, 4 months ago (2015-08-21 20:19:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 20:20:00 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 20:21:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f39ec09100c898b5357b7a6230542229c8f5deb
Cr-Commit-Position: refs/heads/master@{#344848}

Powered by Google App Engine
This is Rietveld 408576698