[Chromecast] ATV: don't include logs from renderer process in logfile.

chromecast/app/cast_main_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/app/cast_main_delegate.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 43 matching lines @@
 CastMainDelegate::CastMainDelegate() {
 }
 
 CastMainDelegate::~CastMainDelegate() {
 }
 
 bool CastMainDelegate::BasicStartupComplete(int* exit_code) {
   RegisterPathProvider();
 
   logging::LoggingSettings settings;
+  settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
 #if defined(OS_ANDROID)
-  base::FilePath log_file;
-  PathService::Get(FILE_CAST_ANDROID_LOG, &log_file);
-  settings.logging_dest = logging::LOG_TO_ALL;
-  settings.log_file = log_file.value().c_str();
   const base::CommandLine* command_line(base::CommandLine::ForCurrentProcess());
   std::string process_type =
       command_line->GetSwitchValueASCII(switches::kProcessType);
-  // Only delete the old logs if the current process is the browser process.
-  // Empty process_type signifies browser process.
-  settings.delete_old = process_type.empty() ? logging::DELETE_OLD_LOG_FILE
-                                             : logging::APPEND_TO_OLD_LOG_FILE;
-#else
-  settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
+  // Browser process logs are recorded for attaching with crash dumps.
+  if (process_type.empty()) {

[slan, 2015/08/21 20:12:14]

Could we add a note about permissions explaining why rendering logs are not
captured? (or perhaps the bug explaining the logcat strategy to capture these
logs eventually?)

+    base::FilePath log_file;
+    PathService::Get(FILE_CAST_ANDROID_LOG, &log_file);
+    settings.logging_dest = logging::LOG_TO_ALL;
+    settings.log_file = log_file.value().c_str();
+    settings.delete_old = logging::DELETE_OLD_LOG_FILE;
+  }
 #endif  // defined(OS_ANDROID)
   logging::InitLogging(settings);
   // Time, process, and thread ID are available through logcat.
   logging::SetLogItems(true, true, false, false);
 
 #if defined(OS_ANDROID)
   // Only delete the old crash dumps if the current process is the browser
   // process. Empty |process_type| signifies browser process.
   if (process_type.empty()) {
     // Get a listing of all of the crash dump files.
@@ skipping 141 matching lines @@
 }
 
 content::ContentRendererClient*
 CastMainDelegate::CreateContentRendererClient() {
   renderer_client_ = CastContentRendererClient::Create();
   return renderer_client_.get();
 }
 
 }  // namespace shell
 }  // namespace chromecast