Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1311463007: Rename some earcons based on actual usage (Closed)

Created:
5 years, 3 months ago by dmazzoni
Modified:
5 years, 3 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@earcons_by_name
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename some earcons based on actual usage BUG=491243 Committed: https://crrev.com/7d766c0ee979d2a0a1fcb5bcda5239def4564cde Cr-Commit-Position: refs/heads/master@{#348559}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Didn't mean to rename ALERT, revert that part #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -26 lines) Patch
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/bullet.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/busy_progress_loop.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/font_change.ogg View Binary file 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/list_item.ogg View Binary file 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/math.ogg View Binary file 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/page_finish_loading.ogg View Binary file 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/page_start_loading.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/paragraph_break.ogg View Binary file 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/recover_focus.ogg View Binary file 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/skip.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/special_content.ogg View Binary file 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/task_success.ogg View Binary file 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_assets.gypi View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/aria_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/description_util.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/abstract_earcons.js View 1 1 chunk +6 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1200133002 Patch 1

Messages

Total messages: 21 (9 generated)
dmazzoni
5 years, 3 months ago (2015-08-27 22:27:33 UTC) #2
Peter Lundblad
https://codereview.chromium.org/1311463007/diff/20001/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js File chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js (right): https://codereview.chromium.org/1311463007/diff/20001/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js#newcode291 chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js:291: * SKIP Are any of these used by api ...
5 years, 3 months ago (2015-08-28 14:47:43 UTC) #3
dmazzoni
https://codereview.chromium.org/1311463007/diff/20001/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js File chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js (right): https://codereview.chromium.org/1311463007/diff/20001/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js#newcode291 chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js:291: * SKIP On 2015/08/28 14:47:43, Peter Lundblad wrote: > ...
5 years, 3 months ago (2015-08-28 18:07:51 UTC) #4
Peter Lundblad
lgtm
5 years, 3 months ago (2015-08-28 18:32:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311463007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311463007/40001
5 years, 3 months ago (2015-09-11 17:39:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/61731)
5 years, 3 months ago (2015-09-11 18:18:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311463007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311463007/60001
5 years, 3 months ago (2015-09-11 22:49:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/94666)
5 years, 3 months ago (2015-09-12 00:27:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311463007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311463007/60001
5 years, 3 months ago (2015-09-14 04:21:38 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-14 04:48:06 UTC) #19
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/7d766c0ee979d2a0a1fcb5bcda5239def4564cde Cr-Commit-Position: refs/heads/master@{#348559}
5 years, 3 months ago (2015-09-14 04:48:44 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:29:16 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/7d766c0ee979d2a0a1fcb5bcda5239def4564cde
Cr-Commit-Position: refs/heads/master@{#348559}

Powered by Google App Engine
This is Rietveld 408576698