chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js - Issue 1311463007: Rename some earcons based on actual usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

Issue 1311463007: Rename some earcons based on actual usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@earcons_by_name

Patch Set: Didn't mean to rename ALERT, revert that part Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/earcons/task_success.ogg ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

index 6d40b881db6eb5c335a4d8625d145f8a4de6b7b2..89d2ce1c1c51cab3f442c8954e6ca12ca6dfc854 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

@@ -115,10 +115,10 @@ cvox.TabsApiHandler.prototype = {

}

if (tab.status == 'loading') {

this.lastActiveTabLoaded_ = false;

- this.earcons_.playEarcon(cvox.Earcon.BUSY_PROGRESS_LOOP);

+ this.earcons_.playEarcon(cvox.Earcon.PAGE_START_LOADING);

} else if (!this.lastActiveTabLoaded_) {

this.lastActiveTabLoaded_ = true;

- this.earcons_.playEarcon(cvox.Earcon.TASK_SUCCESS);

+ this.earcons_.playEarcon(cvox.Earcon.PAGE_FINISH_LOADING);

}

}.bind(this));