Issue 131143006: Revert 247966 "Remove unnecessary dependency from gpu/ to libui.dll"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 131143006: Revert 247966 "Remove unnecessary dependency from gpu/ to libui.dll" (Closed)

Created:
6 years, 10 months ago by xhwang

Modified:
6 years, 10 months ago

Reviewers:
jamesr

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 247966 "Remove unnecessary dependency from gpu/ to libui.dll" > Remove unnecessary dependency from gpu/ to libui.dll > > The command buffer uses ui/gfx/ types and ui/gl/ bindings, but those are > separate components from ui/ui.gyp:ui. libui.dll pulls in a bunch of dependencies > (like net/) that the command buffer doesn't need. > > R=piman > > Review URL: https://codereview.chromium.org/137203006 BUG=339518 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247974

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	trunk/src/gpu/command_buffer_service.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

xhwang

6 years, 10 months ago (2014-01-30 17:10:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r247974 (tree was closed).