Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 137203006: Remove unnecessary dependency from gpu/ to libui.dll (Closed)

Created:
6 years, 11 months ago by jamesr
Modified:
6 years, 10 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Remove unnecessary dependency from gpu/ to libui.dll The command buffer uses ui/gfx/ types and ui/gl/ bindings, but those are separate components from ui/ui.gyp:ui. libui.dll pulls in a bunch of dependencies (like net/) that the command buffer doesn't need. R=piman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M gpu/command_buffer_service.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jamesr
6 years, 11 months ago (2014-01-21 22:31:41 UTC) #1
piman
lgtm
6 years, 11 months ago (2014-01-21 22:37:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/137203006/1
6 years, 11 months ago (2014-01-21 22:42:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/137203006/1
6 years, 11 months ago (2014-01-22 07:04:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/137203006/1
6 years, 10 months ago (2014-01-29 19:26:44 UTC) #7
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test on builder ...
6 years, 10 months ago (2014-01-30 04:44:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/137203006/1
6 years, 10 months ago (2014-01-30 05:07:30 UTC) #9
commit-bot: I haz the power
Change committed as 247966
6 years, 10 months ago (2014-01-30 16:42:16 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 16:42:20 UTC) #11
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698